fix(compiler-cli): flat module index metadata should be transformed #23129
Conversation
| @@ -1013,10 +1015,26 @@ describe('ngc transformer command-line', () => { | |||
| it('should be able to generate a flat module library', () => { | |||
| writeFlatModule('index.js'); | |||
|
|
|||
| debugger; | |||
There was a problem hiding this comment.
just kidding.. I'm sorry, but I couldn't help myself.
There was a problem hiding this comment.
missing a tslint check for that!
| // contents of the flat module index. The bundle produced during emit does use the metadata cache | ||
| // with associated transforms, so the metadata will have lowered expressions, resource inlining, | ||
| // etc. | ||
| const getMetadataBundle = (cache?: MetadataCache) => { |
There was a problem hiding this comment.
nit: I think the compiler use explicit null most often. (also in CompilerHostAdapter)
There was a problem hiding this comment.
nits excluding this change looks good to me, but we should wait for @alexeagle to chime in as well.
| const normalSyntheticIndexName = path.normalize(syntheticIndex.name); | ||
| const indexContent = syntheticIndex.content; | ||
| const indexMetadata = syntheticIndex.metadata; | ||
| const getIndexMetadata = syntheticIndex.getMetadata; |
There was a problem hiding this comment.
nit: I don't care much for these extra variables, they introduce an extra indirection just to save some characters?
|
|
||
| getMetadataFor(fileName: string): ModuleMetadata|undefined { | ||
| if (!this.host.fileExists(fileName + '.ts')) return undefined; | ||
| const sourceFile = this.host.getSourceFile(fileName + '.ts', ts.ScriptTarget.Latest); | ||
| return sourceFile && this.collector.getMetadata(sourceFile); | ||
| // If there is a metadata cache, use it to |
| @@ -1013,10 +1015,26 @@ describe('ngc transformer command-line', () => { | |||
| it('should be able to generate a flat module library', () => { | |||
| writeFlatModule('index.js'); | |||
|
|
|||
| debugger; | |||
There was a problem hiding this comment.
missing a tslint check for that!
Currently, the flat module index metadata is produced directly from the source metadata. The compiler, however, applies transformations on the Typescript sources during transpilation, and also equivalent transformations on the metadata itself. This transformed metadata doesn't end up in the flat module index. This changes the compiler to generate the flat module index metadata from its transformed version instead of directly from source.
alxhub
added
target: major
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Currently, the flat module index metadata is produced directly from
the source metadata. The compiler, however, applies transformations
on the Typescript sources during transpilation, and also equivalent
transformations on the metadata itself. This transformed metadata
doesn't end up in the flat module index.
This changes the compiler to generate the flat module index metadata
from its transformed version instead of directly from source.