Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ivy): generate bind calls for property bindings #23403

Closed
wants to merge 1 commit into from
Closed

fix(ivy): generate bind calls for property bindings #23403

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/compiler/src/render3/r3_view_compiler.ts
View file
Open in desktop
Expand Up @@ -722,7 +722,7 @@ class TemplateDefinitionBuilder implements TemplateAstVisitor, LocalResolver {
// TODO(chuckj): runtime: security context?
this.instruction(
this._bindingMode, input.sourceSpan, instruction, o.literal(elementIndex),
o.literal(input.name), convertedBinding);
o.literal(input.name), o.importExpr(R3.bind).callFn([convertedBinding]));
} else {
this.unsupported(`binding ${PropertyBindingType[input.type]}`);
}
Expand Down
85 changes: 85 additions & 0 deletions packages/compiler/test/render3/r3_compiler_compliance_spec.ts
View file
Open in desktop
Expand Up @@ -65,6 +65,91 @@ describe('compiler compliance', () => {
expectEmit(result.source, factory, 'Incorrect factory');
expectEmit(result.source, template, 'Incorrect template');
});

it('should bind to element properties', () => {
const files = {
app: {
'spec.ts': `
import {Component, NgModule} from '@angular/core';

@Component({
selector: 'my-component',
template: \`<div [id]="id"></div>\`
})
export class MyComponent {
id = 'one';
}

@NgModule({declarations: [MyComponent]})
export class MyModule {}
`
}
};

const factory = 'factory: function MyComponent_Factory() { return new MyComponent(); }';
const template = `
…
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

… is not needed at start (the expectation is not anchored) - same below

template: function MyComponent_Template(rf: IDENT, ctx: IDENT) {
if (rf & 1) {
$r3$.ɵE(0, 'div');
$r3$.ɵe();
}
if (rf & 2) {
$r3$.ɵp(0, 'id', $r3$.ɵb(ctx.id));
}
}
`;


const result = compile(files, angularFiles);

expectEmit(result.source, factory, 'Incorrect factory');
expectEmit(result.source, template, 'Incorrect template');
});

it('should bind to class and style names', () => {
const files = {
app: {
'spec.ts': `
import {Component, NgModule} from '@angular/core';

@Component({
selector: 'my-component',
template: \`<div [class.error]="error" [style.background-color]="color"></div>\`
})
export class MyComponent {
error = true;
color = 'red';
}

@NgModule({declarations: [MyComponent]})
export class MyModule {}
`
}
};

const factory = 'factory: function MyComponent_Factory() { return new MyComponent(); }';
const template = `
…
template: function MyComponent_Template(rf: IDENT, ctx: IDENT) {
if (rf & 1) {
$r3$.ɵE(0, 'div');
$r3$.ɵe();
}
if (rf & 2) {
$r3$.ɵkn(0, 'error', $r3$.ɵb(ctx.error));
$r3$.ɵsn(0, 'background-color', $r3$.ɵb(ctx.color));
}
}
`;


const result = compile(files, angularFiles);

expectEmit(result.source, factory, 'Incorrect factory');
expectEmit(result.source, template, 'Incorrect template');
});

});

describe('components & directives', () => {
Expand Down
4 changes: 2 additions & 2 deletions packages/compiler/test/render3/r3_view_compiler_template_spec.ts
View file
Open in desktop
Expand Up @@ -16,7 +16,7 @@ describe('compiler compliance: template', () => {
compileCommon: true,
});

it('should create correctly bind to context in nested template', () => {
it('should correctly bind to context in nested template', () => {
const files = {
app: {
'spec.ts': `
Expand Down Expand Up @@ -94,7 +94,7 @@ describe('compiler compliance: template', () => {
const $outer$ = ctx0.$implicit;
const $middle$ = ctx1.$implicit;
const $inner$ = ctx2.$implicit;
$i0$.ɵp(0, 'title', ctx.format($outer$, $middle$, $inner$, ctx.component));
$i0$.ɵp(0, 'title', $i0$.ɵb(ctx.format($outer$, $middle$, $inner$, ctx.component)));
$i0$.ɵt(1, $i0$.ɵi1(' ', ctx.format($outer$, $middle$, $inner$, ctx.component), ' '));
}
}
Expand Down