Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ivy): properly destroy view trees where root is an embedded view … #23482

Closed
wants to merge 1 commit into from
Closed

fix(ivy): properly destroy view trees where root is an embedded view … #23482

wants to merge 1 commit into from

Commits on Apr 23, 2018

  1. fix(ivy): properly destroy view trees where root is an embedded view … 

    …without children

The bug fixed here steams from the fact that we are traversing too far up
in the views tree hierarchy in the destroyViewTree function.

The logic in destroyViewTree is off if we start removal at an embedded view
without any child views. For such a case we should just clean up (cleanUpView)
this one view without paying attention to next / parent views.
    @pkozlowski-opensource
    pkozlowski-opensource committed Apr 23, 2018
    Configuration menu
    Copy the full SHA
    718c93d View commit details
    Browse the repository at this point in the history