Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix (printing docs): Added printer friendly code-example background color rule #23496

Closed
wants to merge 3 commits into from

Conversation

SetTrend
Copy link

@SetTrend SetTrend commented Apr 22, 2018

The original SCSS file for printing the documentation is missing a background-color rule for printing, so color/background-color happen to be the same.

I added a light grey background color rule that saves toner and still is immediately recognizable as distinct code example token to the reader.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Currently, CSS color/background-color on the printed version of code examples in the documentation happen to be the same, so the code examples are plain invisible to the reader.
Issue Number: #23431

What is the new behavior?

I added a light grey background color rule to the SCSS file for printing that saves toner and still is immediately recognizable as distinct code example token to the reader:

updated code-example scss

Does this PR introduce a breaking change?

[ ] Yes
[X] No

The original file is missing a background-color rule for printing, so color/background-color happen to be the same.

I added a light grey background color rule that saves toner and still is immediately recognizable as distinct code example token to the reader.
…olor rule

The original SCSS file for printing the documentation is missing a background-color rule for printing, so color/background-color happen to be the same.

I added a light grey background color rule that saves toner and still is immediately recognizable as distinct code example token to the reader.

Closing #23431
The current documentation on Dynamic Component Loading is partially quite ambiguous and, thus, hard to get. I tried to improve wording.

Issue: #23498
@SetTrend SetTrend closed this Apr 22, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants