Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: fix snapshot publishing #23516

Closed
wants to merge 1 commit into from
Closed

ci: fix snapshot publishing #23516

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 5 additions & 1 deletion .circleci/config.yml
View file
Open in desktop
Expand Up @@ -192,8 +192,12 @@ workflows:
# We'd really like to filter out pull requests here, but not yet available:
# https://discuss.circleci.com/t/workflows-pull-request-filter/14396/4
# Instead, the publish-build-artifacts.sh script just terminates when
# CIRCLE_PULL_REQUEST is set.
# CIRCLE_PR_NUMBER is set.
requires:
# Only publish if tests pass
- test
# Get the artifacts to publish from the build-packages-dist job
# since the publishing script expects the legacy outputs layout.
- build-packages-dist

aio_monitoring:
Expand Down
2 changes: 1 addition & 1 deletion scripts/ci/publish-build-artifacts.sh
View file
Open in desktop
Expand Up @@ -126,7 +126,7 @@ if [ $# -gt 0 ]; then
elif [[ \
"$CIRCLE_PROJECT_USERNAME" == "angular" && \
"$CIRCLE_PROJECT_REPONAME" == "angular" && \
! -v CIRCLE_PULL_REQUEST ]]; then
! -v CIRCLE_PR_NUMBER ]]; then
ORG="angular"
# $KEY is set on CI only for non-PR builds. See /.circleci/README.md
openssl aes-256-cbc -d -in .circleci/github_token -k "${KEY}" -out "${HOME}/.git_credentials"
Expand Down