-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(common): do not round factional ms #24831
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vicb
added
action: review
The PR is still awaiting reviews from at least one requested reviewer
area: i18n
labels
Jul 10, 2018
You can preview 3d9e00a at https://pr24831-3d9e00a.ngbuilds.io/. |
You can preview 69b1819 at https://pr24831-69b1819.ngbuilds.io/. |
mhevery
approved these changes
Jul 11, 2018
mhevery
removed
the
action: review
The PR is still awaiting reviews from at least one requested reviewer
label
Jul 11, 2018
mhevery
pushed a commit
that referenced
this pull request
Jul 11, 2018
vicb
added a commit
to vicb/angular
that referenced
this pull request
Jul 11, 2018
fix a bug introduced in angular#24831
vicb
added a commit
to vicb/angular
that referenced
this pull request
Jul 11, 2018
fix a bug introduced in angular#24831
vicb
added a commit
to vicb/angular
that referenced
this pull request
Jul 11, 2018
fix a bug introduced in angular#24831
danielsogl
added a commit
to danielsogl/angular
that referenced
this pull request
Jul 11, 2018
docs: fix typos in 'Httpclient' docs (angular#19127) PR Close angular#19127 docs(router): add `paramsInheritanceStrategy` documentation (angular#22590) PR Close angular#22590 docs: add app.module to changed documents (angular#23876) PR Close angular#23876 docs: clarify faqs about services (angular#24079) PR Close angular#24079 docs(aio): added a link to Angular Zero online course (Traditional Chinese) (angular#24228) PR Close angular#24228 docs: describe rounding behaviour of 'DecimalPipe' (angular#24303) PR Close angular#24303 docs(common): fix in the documentation of PUT (angular#24528) PR Close angular#24528 docs: add workspace and related cli terms (angular#24633) PR Close angular#24633 docs(changelog): correct inaccuracies (angular#24713) PR Close angular#24713 test: integration test for TS 2.9.x (angular#24749) PR Close angular#24749 fix(ivy): pipes are pure by default (angular#24750) PR Close angular#24750 build(bazel): update to rule_nodejs 0.10.0 (angular#24759) PR Close angular#24759 build: upgrade jasmine (and related typings) to latest version (angular#19904) With these changes, the types are a little stricter now and also not compatible with Protractor's jasmine-like syntax. So, we have to also use `@types/jasminewd2` for e2e tests (but not for non-e2e tests). I also had to "augment" `@types/jasminewd2`, because the latest typings from [DefinitelyTyped][1] do not reflect the fact that the `jasminewd2` version (v2.1.0) currently used by Protractor supports passing a `done` callback to a spec. [1]: https://github.com/DefinitelyTyped/DefinitelyTyped/blob/566e0394859fdc1dc893658ccec6b06372d56a91/types/jasminewd2/index.d.ts#L9-L15 Fixes angular#23952 Closes angular#24733 PR Close angular#19904 test: make `NgMatchers` type-aware (angular#19904) PR Close angular#19904 refactor: infer type for `it()` assertion functions (angular#19904) PR Close angular#19904 build: upgrade jasmine to 2.99.x and fix tests (angular#19904) PR Close angular#19904 refactor: re-organize and "modernize" cjs-jasmine scripts (angular#19904) PR Close angular#19904 test: run unit tests in random order (angular#19904) PR Close angular#19904 build: upgrade jasmine to 3.1.0 (angular#19904) PR Close angular#19904 build: upgrade karma and related dependencies (angular#19904) PR Close angular#19904 docs: refactored ng-container code (angular#22742) PR Close angular#22742 docs: update Angular Boot Camp description (angular#23653) PR Close angular#23653 feat(service-worker): add support for `?` in SW config globbing (angular#24105) The globbing is used in the following sections: - `assetGroups` > `resources` > `files`/`versionedFiles` - `assetGroups` > `resources` > `urls` - `dataGroups` > `urls` - `navigationUrls` Query params are ignored for `files`/`versionedFiles` and `navigationUrls`, but they are still taken into account for `assetGroups`/`dataGroups` `urls`. To avoid a breaking change, `?` is matched literally for these patterns. PR Close angular#24105 refactor(service-worker): avoid unnecessary operations and remove unused code (angular#24127) PR Close angular#24127 fix(service-worker): avoid network requests when looking up hashed resources in cache (angular#24127) PR Close angular#24127 feat(ivy): properly apply style="", [style], [style.foo] and [attr.style] bindings (angular#24602) PR Close angular#24602 fix(language-service): do not overwrite native `Reflect` (angular#24299) Fixes angular#21420 PR Close angular#24299 fix(common): use correct currency format for locale de-AT (angular#24658) Fixes angular#24609 PR Close angular#24658 fix(ivy): correctly resolve Array property access (angular#24664) PR Close angular#24664 build: make `internal-angular` karma reporter compatible with latest karma (angular#24803) Due to changes in karma@1.0.0, `internal-angular` karma reporter stopped showing browser logs (such as `console.log()` etc.). Related to d571a51. PR Close angular#24803 build: remove unnecessary `internal-angular` karma reporter (angular#24803) The reporter was added in 87d56ac, with the purpose of fixing source-map paths (which was apparently needed back then). Things have moved around a lot since then and the custom reporter doesn't seem to be necessary any more. By removing the reporter, we have one less thing to worry about while upgrading karma; plus we get improvements in built-in reporters for free. Output with the custom reporter: ``` at someMethod (packages/core/.../some-file.ts:13:37) ``` Output with the built-in reporter: ``` at someMethod (packages/core/.../some-file.ts:13.37 <- dist/all/@angular/core/.../some-file.js:1:337) ``` PR Close angular#24803 fix(core): mark NgModule as not the root if APP_ROOT is set to false (angular#24814) Tree shakable providers use the APP_ROOT token to determine where to attach themselves. APP_ROOT gets set on NgModule with BrowserModule irrespective of whether it is actually the root(Ex. in case of SSR app where the shell app is first bootstrapped without BrowserModule being the root module). This change allows a NgModule with BrowserModule to explicitly mark itself as not the root by setting APP_ROOT token to false. This allows tree shakable providers to be attached to the right rott module. PR Close angular#24814 fix(platform-browser): mark Meta and Title services as tree shakable providers (angular#24815) This lets services that use Meta and Title services to be tree shakable and provided in root. PR Close angular#24815 docs(aio): unified console.log single string style (angular#22737) PR Close angular#22737 docs: unified console.log single string style (angular#22737) PR Close angular#22737 fix(compiler-cli): Use typescript to resolve modules for metadata (angular#22856) The current module resolution simply attaches .ts to the import/export path, which does not work if the path is using Node / CommonJS behavior to resolve to an index.ts file. This patch uses typescript's module resolution logic, and will attempt to load the original typescript file if this resolution returns a .js or .d.ts file PR Close angular#22856 docs: clarify wording in architecture overview (angular#24481) Closes angular#23463 Closes angular#22158 PR Close angular#24481 docs: add tree-shakable providers (angular#24481) PR Close angular#24481 fix(ivy): support projecting into dynamic views (angular#24752) PR Close angular#24752 refactor(ivy): replace pNextOrParent with TNode props (angular#24752) PR Close angular#24752 docs: fix typo in Universal guide (angular#24812) PR Close angular#24812 fix(platform-browser): workaround wrong import path generated by ngc for DOCUMENT (angular#24830) docs: correct project definition (angular#24807) PR Close angular#24807 build: update to latest nodejs bazel rules (angular#24817) PR Close angular#24817 fix(common): do not round factional seconds (angular#24831) fixes angular#24384 PR Close angular#24831 docs: fix typos referencing inline component styles (angular#22557) PR Close angular#22557 fix(router): add ability to recover from malformed url (angular#23283) Fixes angular#21468 PR Close angular#23283 docs: fix incorrect forms selector references (angular#22631) PR Close angular#22631 docs(aio): unified string chaining (angular#22735) PR Close angular#22735 docs: unified string chaining (angular#22735) PR Close angular#22735 docs(forms): added missing backtick (angular#24451) Fixed trivial markdown problem with a missing backtick. PR Close angular#24451 docs(forms): update API reference for form validators (angular#24734) PR Close angular#24734 Merge remote-tracking branch 'upstream/master' into refactor-example-pipe
mhevery
pushed a commit
that referenced
this pull request
Jul 11, 2018
mhevery
pushed a commit
that referenced
this pull request
Jul 11, 2018
danielsogl
added a commit
to danielsogl/angular
that referenced
this pull request
Jul 18, 2018
docs: fix typos in 'Httpclient' docs (angular#19127) PR Close angular#19127 docs(router): add `paramsInheritanceStrategy` documentation (angular#22590) PR Close angular#22590 docs: add app.module to changed documents (angular#23876) PR Close angular#23876 docs: clarify faqs about services (angular#24079) PR Close angular#24079 docs(aio): added a link to Angular Zero online course (Traditional Chinese) (angular#24228) PR Close angular#24228 docs: describe rounding behaviour of 'DecimalPipe' (angular#24303) PR Close angular#24303 docs(common): fix in the documentation of PUT (angular#24528) PR Close angular#24528 docs: add workspace and related cli terms (angular#24633) PR Close angular#24633 docs(changelog): correct inaccuracies (angular#24713) PR Close angular#24713 test: integration test for TS 2.9.x (angular#24749) PR Close angular#24749 fix(ivy): pipes are pure by default (angular#24750) PR Close angular#24750 build(bazel): update to rule_nodejs 0.10.0 (angular#24759) PR Close angular#24759 build: upgrade jasmine (and related typings) to latest version (angular#19904) With these changes, the types are a little stricter now and also not compatible with Protractor's jasmine-like syntax. So, we have to also use `@types/jasminewd2` for e2e tests (but not for non-e2e tests). I also had to "augment" `@types/jasminewd2`, because the latest typings from [DefinitelyTyped][1] do not reflect the fact that the `jasminewd2` version (v2.1.0) currently used by Protractor supports passing a `done` callback to a spec. [1]: https://github.com/DefinitelyTyped/DefinitelyTyped/blob/566e0394859fdc1dc893658ccec6b06372d56a91/types/jasminewd2/index.d.ts#L9-L15 Fixes angular#23952 Closes angular#24733 PR Close angular#19904 test: make `NgMatchers` type-aware (angular#19904) PR Close angular#19904 refactor: infer type for `it()` assertion functions (angular#19904) PR Close angular#19904 build: upgrade jasmine to 2.99.x and fix tests (angular#19904) PR Close angular#19904 refactor: re-organize and "modernize" cjs-jasmine scripts (angular#19904) PR Close angular#19904 test: run unit tests in random order (angular#19904) PR Close angular#19904 build: upgrade jasmine to 3.1.0 (angular#19904) PR Close angular#19904 build: upgrade karma and related dependencies (angular#19904) PR Close angular#19904 docs: refactored ng-container code (angular#22742) PR Close angular#22742 docs: update Angular Boot Camp description (angular#23653) PR Close angular#23653 feat(service-worker): add support for `?` in SW config globbing (angular#24105) The globbing is used in the following sections: - `assetGroups` > `resources` > `files`/`versionedFiles` - `assetGroups` > `resources` > `urls` - `dataGroups` > `urls` - `navigationUrls` Query params are ignored for `files`/`versionedFiles` and `navigationUrls`, but they are still taken into account for `assetGroups`/`dataGroups` `urls`. To avoid a breaking change, `?` is matched literally for these patterns. PR Close angular#24105 refactor(service-worker): avoid unnecessary operations and remove unused code (angular#24127) PR Close angular#24127 fix(service-worker): avoid network requests when looking up hashed resources in cache (angular#24127) PR Close angular#24127 feat(ivy): properly apply style="", [style], [style.foo] and [attr.style] bindings (angular#24602) PR Close angular#24602 fix(language-service): do not overwrite native `Reflect` (angular#24299) Fixes angular#21420 PR Close angular#24299 fix(common): use correct currency format for locale de-AT (angular#24658) Fixes angular#24609 PR Close angular#24658 fix(ivy): correctly resolve Array property access (angular#24664) PR Close angular#24664 build: make `internal-angular` karma reporter compatible with latest karma (angular#24803) Due to changes in karma@1.0.0, `internal-angular` karma reporter stopped showing browser logs (such as `console.log()` etc.). Related to d571a51. PR Close angular#24803 build: remove unnecessary `internal-angular` karma reporter (angular#24803) The reporter was added in 87d56ac, with the purpose of fixing source-map paths (which was apparently needed back then). Things have moved around a lot since then and the custom reporter doesn't seem to be necessary any more. By removing the reporter, we have one less thing to worry about while upgrading karma; plus we get improvements in built-in reporters for free. Output with the custom reporter: ``` at someMethod (packages/core/.../some-file.ts:13:37) ``` Output with the built-in reporter: ``` at someMethod (packages/core/.../some-file.ts:13.37 <- dist/all/@angular/core/.../some-file.js:1:337) ``` PR Close angular#24803 fix(core): mark NgModule as not the root if APP_ROOT is set to false (angular#24814) Tree shakable providers use the APP_ROOT token to determine where to attach themselves. APP_ROOT gets set on NgModule with BrowserModule irrespective of whether it is actually the root(Ex. in case of SSR app where the shell app is first bootstrapped without BrowserModule being the root module). This change allows a NgModule with BrowserModule to explicitly mark itself as not the root by setting APP_ROOT token to false. This allows tree shakable providers to be attached to the right rott module. PR Close angular#24814 fix(platform-browser): mark Meta and Title services as tree shakable providers (angular#24815) This lets services that use Meta and Title services to be tree shakable and provided in root. PR Close angular#24815 docs(aio): unified console.log single string style (angular#22737) PR Close angular#22737 docs: unified console.log single string style (angular#22737) PR Close angular#22737 fix(compiler-cli): Use typescript to resolve modules for metadata (angular#22856) The current module resolution simply attaches .ts to the import/export path, which does not work if the path is using Node / CommonJS behavior to resolve to an index.ts file. This patch uses typescript's module resolution logic, and will attempt to load the original typescript file if this resolution returns a .js or .d.ts file PR Close angular#22856 docs: clarify wording in architecture overview (angular#24481) Closes angular#23463 Closes angular#22158 PR Close angular#24481 docs: add tree-shakable providers (angular#24481) PR Close angular#24481 fix(ivy): support projecting into dynamic views (angular#24752) PR Close angular#24752 refactor(ivy): replace pNextOrParent with TNode props (angular#24752) PR Close angular#24752 docs: fix typo in Universal guide (angular#24812) PR Close angular#24812 fix(platform-browser): workaround wrong import path generated by ngc for DOCUMENT (angular#24830) docs: correct project definition (angular#24807) PR Close angular#24807 build: update to latest nodejs bazel rules (angular#24817) PR Close angular#24817 fix(common): do not round factional seconds (angular#24831) fixes angular#24384 PR Close angular#24831 docs: fix typos referencing inline component styles (angular#22557) PR Close angular#22557 fix(router): add ability to recover from malformed url (angular#23283) Fixes angular#21468 PR Close angular#23283 docs: fix incorrect forms selector references (angular#22631) PR Close angular#22631 docs(aio): unified string chaining (angular#22735) PR Close angular#22735 docs: unified string chaining (angular#22735) PR Close angular#22735 docs(forms): added missing backtick (angular#24451) Fixed trivial markdown problem with a missing backtick. PR Close angular#24451 docs(forms): update API reference for form validators (angular#24734) PR Close angular#24734 Merge remote-tracking branch 'upstream/master' into refactor-example-pipe
danielsogl
added a commit
to danielsogl/angular
that referenced
this pull request
Jul 20, 2018
docs: fix typos in 'Httpclient' docs (angular#19127) PR Close angular#19127 docs(router): add `paramsInheritanceStrategy` documentation (angular#22590) PR Close angular#22590 docs: add app.module to changed documents (angular#23876) PR Close angular#23876 docs: clarify faqs about services (angular#24079) PR Close angular#24079 docs(aio): added a link to Angular Zero online course (Traditional Chinese) (angular#24228) PR Close angular#24228 docs: describe rounding behaviour of 'DecimalPipe' (angular#24303) PR Close angular#24303 docs(common): fix in the documentation of PUT (angular#24528) PR Close angular#24528 docs: add workspace and related cli terms (angular#24633) PR Close angular#24633 docs(changelog): correct inaccuracies (angular#24713) PR Close angular#24713 test: integration test for TS 2.9.x (angular#24749) PR Close angular#24749 fix(ivy): pipes are pure by default (angular#24750) PR Close angular#24750 build(bazel): update to rule_nodejs 0.10.0 (angular#24759) PR Close angular#24759 build: upgrade jasmine (and related typings) to latest version (angular#19904) With these changes, the types are a little stricter now and also not compatible with Protractor's jasmine-like syntax. So, we have to also use `@types/jasminewd2` for e2e tests (but not for non-e2e tests). I also had to "augment" `@types/jasminewd2`, because the latest typings from [DefinitelyTyped][1] do not reflect the fact that the `jasminewd2` version (v2.1.0) currently used by Protractor supports passing a `done` callback to a spec. [1]: https://github.com/DefinitelyTyped/DefinitelyTyped/blob/566e0394859fdc1dc893658ccec6b06372d56a91/types/jasminewd2/index.d.ts#L9-L15 Fixes angular#23952 Closes angular#24733 PR Close angular#19904 test: make `NgMatchers` type-aware (angular#19904) PR Close angular#19904 refactor: infer type for `it()` assertion functions (angular#19904) PR Close angular#19904 build: upgrade jasmine to 2.99.x and fix tests (angular#19904) PR Close angular#19904 refactor: re-organize and "modernize" cjs-jasmine scripts (angular#19904) PR Close angular#19904 test: run unit tests in random order (angular#19904) PR Close angular#19904 build: upgrade jasmine to 3.1.0 (angular#19904) PR Close angular#19904 build: upgrade karma and related dependencies (angular#19904) PR Close angular#19904 docs: refactored ng-container code (angular#22742) PR Close angular#22742 docs: update Angular Boot Camp description (angular#23653) PR Close angular#23653 feat(service-worker): add support for `?` in SW config globbing (angular#24105) The globbing is used in the following sections: - `assetGroups` > `resources` > `files`/`versionedFiles` - `assetGroups` > `resources` > `urls` - `dataGroups` > `urls` - `navigationUrls` Query params are ignored for `files`/`versionedFiles` and `navigationUrls`, but they are still taken into account for `assetGroups`/`dataGroups` `urls`. To avoid a breaking change, `?` is matched literally for these patterns. PR Close angular#24105 refactor(service-worker): avoid unnecessary operations and remove unused code (angular#24127) PR Close angular#24127 fix(service-worker): avoid network requests when looking up hashed resources in cache (angular#24127) PR Close angular#24127 feat(ivy): properly apply style="", [style], [style.foo] and [attr.style] bindings (angular#24602) PR Close angular#24602 fix(language-service): do not overwrite native `Reflect` (angular#24299) Fixes angular#21420 PR Close angular#24299 fix(common): use correct currency format for locale de-AT (angular#24658) Fixes angular#24609 PR Close angular#24658 fix(ivy): correctly resolve Array property access (angular#24664) PR Close angular#24664 build: make `internal-angular` karma reporter compatible with latest karma (angular#24803) Due to changes in karma@1.0.0, `internal-angular` karma reporter stopped showing browser logs (such as `console.log()` etc.). Related to d571a51. PR Close angular#24803 build: remove unnecessary `internal-angular` karma reporter (angular#24803) The reporter was added in 87d56ac, with the purpose of fixing source-map paths (which was apparently needed back then). Things have moved around a lot since then and the custom reporter doesn't seem to be necessary any more. By removing the reporter, we have one less thing to worry about while upgrading karma; plus we get improvements in built-in reporters for free. Output with the custom reporter: ``` at someMethod (packages/core/.../some-file.ts:13:37) ``` Output with the built-in reporter: ``` at someMethod (packages/core/.../some-file.ts:13.37 <- dist/all/@angular/core/.../some-file.js:1:337) ``` PR Close angular#24803 fix(core): mark NgModule as not the root if APP_ROOT is set to false (angular#24814) Tree shakable providers use the APP_ROOT token to determine where to attach themselves. APP_ROOT gets set on NgModule with BrowserModule irrespective of whether it is actually the root(Ex. in case of SSR app where the shell app is first bootstrapped without BrowserModule being the root module). This change allows a NgModule with BrowserModule to explicitly mark itself as not the root by setting APP_ROOT token to false. This allows tree shakable providers to be attached to the right rott module. PR Close angular#24814 fix(platform-browser): mark Meta and Title services as tree shakable providers (angular#24815) This lets services that use Meta and Title services to be tree shakable and provided in root. PR Close angular#24815 docs(aio): unified console.log single string style (angular#22737) PR Close angular#22737 docs: unified console.log single string style (angular#22737) PR Close angular#22737 fix(compiler-cli): Use typescript to resolve modules for metadata (angular#22856) The current module resolution simply attaches .ts to the import/export path, which does not work if the path is using Node / CommonJS behavior to resolve to an index.ts file. This patch uses typescript's module resolution logic, and will attempt to load the original typescript file if this resolution returns a .js or .d.ts file PR Close angular#22856 docs: clarify wording in architecture overview (angular#24481) Closes angular#23463 Closes angular#22158 PR Close angular#24481 docs: add tree-shakable providers (angular#24481) PR Close angular#24481 fix(ivy): support projecting into dynamic views (angular#24752) PR Close angular#24752 refactor(ivy): replace pNextOrParent with TNode props (angular#24752) PR Close angular#24752 docs: fix typo in Universal guide (angular#24812) PR Close angular#24812 fix(platform-browser): workaround wrong import path generated by ngc for DOCUMENT (angular#24830) docs: correct project definition (angular#24807) PR Close angular#24807 build: update to latest nodejs bazel rules (angular#24817) PR Close angular#24817 fix(common): do not round factional seconds (angular#24831) fixes angular#24384 PR Close angular#24831 docs: fix typos referencing inline component styles (angular#22557) PR Close angular#22557 fix(router): add ability to recover from malformed url (angular#23283) Fixes angular#21468 PR Close angular#23283 docs: fix incorrect forms selector references (angular#22631) PR Close angular#22631 docs(aio): unified string chaining (angular#22735) PR Close angular#22735 docs: unified string chaining (angular#22735) PR Close angular#22735 docs(forms): added missing backtick (angular#24451) Fixed trivial markdown problem with a missing backtick. PR Close angular#24451 docs(forms): update API reference for form validators (angular#24734) PR Close angular#24734 Merge remote-tracking branch 'upstream/master' into refactor-example-pipe
danielsogl
added a commit
to danielsogl/angular
that referenced
this pull request
Jul 20, 2018
docs: fix typos in 'Httpclient' docs (angular#19127) PR Close angular#19127 docs(router): add `paramsInheritanceStrategy` documentation (angular#22590) PR Close angular#22590 docs: add app.module to changed documents (angular#23876) PR Close angular#23876 docs: clarify faqs about services (angular#24079) PR Close angular#24079 docs(aio): added a link to Angular Zero online course (Traditional Chinese) (angular#24228) PR Close angular#24228 docs: describe rounding behaviour of 'DecimalPipe' (angular#24303) PR Close angular#24303 docs(common): fix in the documentation of PUT (angular#24528) PR Close angular#24528 docs: add workspace and related cli terms (angular#24633) PR Close angular#24633 docs(changelog): correct inaccuracies (angular#24713) PR Close angular#24713 test: integration test for TS 2.9.x (angular#24749) PR Close angular#24749 fix(ivy): pipes are pure by default (angular#24750) PR Close angular#24750 build(bazel): update to rule_nodejs 0.10.0 (angular#24759) PR Close angular#24759 build: upgrade jasmine (and related typings) to latest version (angular#19904) With these changes, the types are a little stricter now and also not compatible with Protractor's jasmine-like syntax. So, we have to also use `@types/jasminewd2` for e2e tests (but not for non-e2e tests). I also had to "augment" `@types/jasminewd2`, because the latest typings from [DefinitelyTyped][1] do not reflect the fact that the `jasminewd2` version (v2.1.0) currently used by Protractor supports passing a `done` callback to a spec. [1]: https://github.com/DefinitelyTyped/DefinitelyTyped/blob/566e0394859fdc1dc893658ccec6b06372d56a91/types/jasminewd2/index.d.ts#L9-L15 Fixes angular#23952 Closes angular#24733 PR Close angular#19904 test: make `NgMatchers` type-aware (angular#19904) PR Close angular#19904 refactor: infer type for `it()` assertion functions (angular#19904) PR Close angular#19904 build: upgrade jasmine to 2.99.x and fix tests (angular#19904) PR Close angular#19904 refactor: re-organize and "modernize" cjs-jasmine scripts (angular#19904) PR Close angular#19904 test: run unit tests in random order (angular#19904) PR Close angular#19904 build: upgrade jasmine to 3.1.0 (angular#19904) PR Close angular#19904 build: upgrade karma and related dependencies (angular#19904) PR Close angular#19904 docs: refactored ng-container code (angular#22742) PR Close angular#22742 docs: update Angular Boot Camp description (angular#23653) PR Close angular#23653 feat(service-worker): add support for `?` in SW config globbing (angular#24105) The globbing is used in the following sections: - `assetGroups` > `resources` > `files`/`versionedFiles` - `assetGroups` > `resources` > `urls` - `dataGroups` > `urls` - `navigationUrls` Query params are ignored for `files`/`versionedFiles` and `navigationUrls`, but they are still taken into account for `assetGroups`/`dataGroups` `urls`. To avoid a breaking change, `?` is matched literally for these patterns. PR Close angular#24105 refactor(service-worker): avoid unnecessary operations and remove unused code (angular#24127) PR Close angular#24127 fix(service-worker): avoid network requests when looking up hashed resources in cache (angular#24127) PR Close angular#24127 feat(ivy): properly apply style="", [style], [style.foo] and [attr.style] bindings (angular#24602) PR Close angular#24602 fix(language-service): do not overwrite native `Reflect` (angular#24299) Fixes angular#21420 PR Close angular#24299 fix(common): use correct currency format for locale de-AT (angular#24658) Fixes angular#24609 PR Close angular#24658 fix(ivy): correctly resolve Array property access (angular#24664) PR Close angular#24664 build: make `internal-angular` karma reporter compatible with latest karma (angular#24803) Due to changes in karma@1.0.0, `internal-angular` karma reporter stopped showing browser logs (such as `console.log()` etc.). Related to d571a51. PR Close angular#24803 build: remove unnecessary `internal-angular` karma reporter (angular#24803) The reporter was added in 87d56ac, with the purpose of fixing source-map paths (which was apparently needed back then). Things have moved around a lot since then and the custom reporter doesn't seem to be necessary any more. By removing the reporter, we have one less thing to worry about while upgrading karma; plus we get improvements in built-in reporters for free. Output with the custom reporter: ``` at someMethod (packages/core/.../some-file.ts:13:37) ``` Output with the built-in reporter: ``` at someMethod (packages/core/.../some-file.ts:13.37 <- dist/all/@angular/core/.../some-file.js:1:337) ``` PR Close angular#24803 fix(core): mark NgModule as not the root if APP_ROOT is set to false (angular#24814) Tree shakable providers use the APP_ROOT token to determine where to attach themselves. APP_ROOT gets set on NgModule with BrowserModule irrespective of whether it is actually the root(Ex. in case of SSR app where the shell app is first bootstrapped without BrowserModule being the root module). This change allows a NgModule with BrowserModule to explicitly mark itself as not the root by setting APP_ROOT token to false. This allows tree shakable providers to be attached to the right rott module. PR Close angular#24814 fix(platform-browser): mark Meta and Title services as tree shakable providers (angular#24815) This lets services that use Meta and Title services to be tree shakable and provided in root. PR Close angular#24815 docs(aio): unified console.log single string style (angular#22737) PR Close angular#22737 docs: unified console.log single string style (angular#22737) PR Close angular#22737 fix(compiler-cli): Use typescript to resolve modules for metadata (angular#22856) The current module resolution simply attaches .ts to the import/export path, which does not work if the path is using Node / CommonJS behavior to resolve to an index.ts file. This patch uses typescript's module resolution logic, and will attempt to load the original typescript file if this resolution returns a .js or .d.ts file PR Close angular#22856 docs: clarify wording in architecture overview (angular#24481) Closes angular#23463 Closes angular#22158 PR Close angular#24481 docs: add tree-shakable providers (angular#24481) PR Close angular#24481 fix(ivy): support projecting into dynamic views (angular#24752) PR Close angular#24752 refactor(ivy): replace pNextOrParent with TNode props (angular#24752) PR Close angular#24752 docs: fix typo in Universal guide (angular#24812) PR Close angular#24812 fix(platform-browser): workaround wrong import path generated by ngc for DOCUMENT (angular#24830) docs: correct project definition (angular#24807) PR Close angular#24807 build: update to latest nodejs bazel rules (angular#24817) PR Close angular#24817 fix(common): do not round factional seconds (angular#24831) fixes angular#24384 PR Close angular#24831 docs: fix typos referencing inline component styles (angular#22557) PR Close angular#22557 fix(router): add ability to recover from malformed url (angular#23283) Fixes angular#21468 PR Close angular#23283 docs: fix incorrect forms selector references (angular#22631) PR Close angular#22631 docs(aio): unified string chaining (angular#22735) PR Close angular#22735 docs: unified string chaining (angular#22735) PR Close angular#22735 docs(forms): added missing backtick (angular#24451) Fixed trivial markdown problem with a missing backtick. PR Close angular#24451 docs(forms): update API reference for form validators (angular#24734) PR Close angular#24734 Merge remote-tracking branch 'upstream/master' into refactor-example-pipe docs: refactor pipe example to use the HttpClient
danielsogl
added a commit
to danielsogl/angular
that referenced
this pull request
Jul 25, 2018
docs: fix typos in 'Httpclient' docs (angular#19127) PR Close angular#19127 docs(router): add `paramsInheritanceStrategy` documentation (angular#22590) PR Close angular#22590 docs: add app.module to changed documents (angular#23876) PR Close angular#23876 docs: clarify faqs about services (angular#24079) PR Close angular#24079 docs(aio): added a link to Angular Zero online course (Traditional Chinese) (angular#24228) PR Close angular#24228 docs: describe rounding behaviour of 'DecimalPipe' (angular#24303) PR Close angular#24303 docs(common): fix in the documentation of PUT (angular#24528) PR Close angular#24528 docs: add workspace and related cli terms (angular#24633) PR Close angular#24633 docs(changelog): correct inaccuracies (angular#24713) PR Close angular#24713 test: integration test for TS 2.9.x (angular#24749) PR Close angular#24749 fix(ivy): pipes are pure by default (angular#24750) PR Close angular#24750 build(bazel): update to rule_nodejs 0.10.0 (angular#24759) PR Close angular#24759 build: upgrade jasmine (and related typings) to latest version (angular#19904) With these changes, the types are a little stricter now and also not compatible with Protractor's jasmine-like syntax. So, we have to also use `@types/jasminewd2` for e2e tests (but not for non-e2e tests). I also had to "augment" `@types/jasminewd2`, because the latest typings from [DefinitelyTyped][1] do not reflect the fact that the `jasminewd2` version (v2.1.0) currently used by Protractor supports passing a `done` callback to a spec. [1]: https://github.com/DefinitelyTyped/DefinitelyTyped/blob/566e0394859fdc1dc893658ccec6b06372d56a91/types/jasminewd2/index.d.ts#L9-L15 Fixes angular#23952 Closes angular#24733 PR Close angular#19904 test: make `NgMatchers` type-aware (angular#19904) PR Close angular#19904 refactor: infer type for `it()` assertion functions (angular#19904) PR Close angular#19904 build: upgrade jasmine to 2.99.x and fix tests (angular#19904) PR Close angular#19904 refactor: re-organize and "modernize" cjs-jasmine scripts (angular#19904) PR Close angular#19904 test: run unit tests in random order (angular#19904) PR Close angular#19904 build: upgrade jasmine to 3.1.0 (angular#19904) PR Close angular#19904 build: upgrade karma and related dependencies (angular#19904) PR Close angular#19904 docs: refactored ng-container code (angular#22742) PR Close angular#22742 docs: update Angular Boot Camp description (angular#23653) PR Close angular#23653 feat(service-worker): add support for `?` in SW config globbing (angular#24105) The globbing is used in the following sections: - `assetGroups` > `resources` > `files`/`versionedFiles` - `assetGroups` > `resources` > `urls` - `dataGroups` > `urls` - `navigationUrls` Query params are ignored for `files`/`versionedFiles` and `navigationUrls`, but they are still taken into account for `assetGroups`/`dataGroups` `urls`. To avoid a breaking change, `?` is matched literally for these patterns. PR Close angular#24105 refactor(service-worker): avoid unnecessary operations and remove unused code (angular#24127) PR Close angular#24127 fix(service-worker): avoid network requests when looking up hashed resources in cache (angular#24127) PR Close angular#24127 feat(ivy): properly apply style="", [style], [style.foo] and [attr.style] bindings (angular#24602) PR Close angular#24602 fix(language-service): do not overwrite native `Reflect` (angular#24299) Fixes angular#21420 PR Close angular#24299 fix(common): use correct currency format for locale de-AT (angular#24658) Fixes angular#24609 PR Close angular#24658 fix(ivy): correctly resolve Array property access (angular#24664) PR Close angular#24664 build: make `internal-angular` karma reporter compatible with latest karma (angular#24803) Due to changes in karma@1.0.0, `internal-angular` karma reporter stopped showing browser logs (such as `console.log()` etc.). Related to d571a51. PR Close angular#24803 build: remove unnecessary `internal-angular` karma reporter (angular#24803) The reporter was added in 87d56ac, with the purpose of fixing source-map paths (which was apparently needed back then). Things have moved around a lot since then and the custom reporter doesn't seem to be necessary any more. By removing the reporter, we have one less thing to worry about while upgrading karma; plus we get improvements in built-in reporters for free. Output with the custom reporter: ``` at someMethod (packages/core/.../some-file.ts:13:37) ``` Output with the built-in reporter: ``` at someMethod (packages/core/.../some-file.ts:13.37 <- dist/all/@angular/core/.../some-file.js:1:337) ``` PR Close angular#24803 fix(core): mark NgModule as not the root if APP_ROOT is set to false (angular#24814) Tree shakable providers use the APP_ROOT token to determine where to attach themselves. APP_ROOT gets set on NgModule with BrowserModule irrespective of whether it is actually the root(Ex. in case of SSR app where the shell app is first bootstrapped without BrowserModule being the root module). This change allows a NgModule with BrowserModule to explicitly mark itself as not the root by setting APP_ROOT token to false. This allows tree shakable providers to be attached to the right rott module. PR Close angular#24814 fix(platform-browser): mark Meta and Title services as tree shakable providers (angular#24815) This lets services that use Meta and Title services to be tree shakable and provided in root. PR Close angular#24815 docs(aio): unified console.log single string style (angular#22737) PR Close angular#22737 docs: unified console.log single string style (angular#22737) PR Close angular#22737 fix(compiler-cli): Use typescript to resolve modules for metadata (angular#22856) The current module resolution simply attaches .ts to the import/export path, which does not work if the path is using Node / CommonJS behavior to resolve to an index.ts file. This patch uses typescript's module resolution logic, and will attempt to load the original typescript file if this resolution returns a .js or .d.ts file PR Close angular#22856 docs: clarify wording in architecture overview (angular#24481) Closes angular#23463 Closes angular#22158 PR Close angular#24481 docs: add tree-shakable providers (angular#24481) PR Close angular#24481 fix(ivy): support projecting into dynamic views (angular#24752) PR Close angular#24752 refactor(ivy): replace pNextOrParent with TNode props (angular#24752) PR Close angular#24752 docs: fix typo in Universal guide (angular#24812) PR Close angular#24812 fix(platform-browser): workaround wrong import path generated by ngc for DOCUMENT (angular#24830) docs: correct project definition (angular#24807) PR Close angular#24807 build: update to latest nodejs bazel rules (angular#24817) PR Close angular#24817 fix(common): do not round factional seconds (angular#24831) fixes angular#24384 PR Close angular#24831 docs: fix typos referencing inline component styles (angular#22557) PR Close angular#22557 fix(router): add ability to recover from malformed url (angular#23283) Fixes angular#21468 PR Close angular#23283 docs: fix incorrect forms selector references (angular#22631) PR Close angular#22631 docs(aio): unified string chaining (angular#22735) PR Close angular#22735 docs: unified string chaining (angular#22735) PR Close angular#22735 docs(forms): added missing backtick (angular#24451) Fixed trivial markdown problem with a missing backtick. PR Close angular#24451 docs(forms): update API reference for form validators (angular#24734) PR Close angular#24734 Merge remote-tracking branch 'upstream/master' into refactor-example-pipe docs: refactor pipe example to use the HttpClient
danielsogl
added a commit
to danielsogl/angular
that referenced
this pull request
Jul 25, 2018
docs: fix typos in 'Httpclient' docs (angular#19127) PR Close angular#19127 docs(router): add `paramsInheritanceStrategy` documentation (angular#22590) PR Close angular#22590 docs: add app.module to changed documents (angular#23876) PR Close angular#23876 docs: clarify faqs about services (angular#24079) PR Close angular#24079 docs(aio): added a link to Angular Zero online course (Traditional Chinese) (angular#24228) PR Close angular#24228 docs: describe rounding behaviour of 'DecimalPipe' (angular#24303) PR Close angular#24303 docs(common): fix in the documentation of PUT (angular#24528) PR Close angular#24528 docs: add workspace and related cli terms (angular#24633) PR Close angular#24633 docs(changelog): correct inaccuracies (angular#24713) PR Close angular#24713 test: integration test for TS 2.9.x (angular#24749) PR Close angular#24749 fix(ivy): pipes are pure by default (angular#24750) PR Close angular#24750 build(bazel): update to rule_nodejs 0.10.0 (angular#24759) PR Close angular#24759 build: upgrade jasmine (and related typings) to latest version (angular#19904) With these changes, the types are a little stricter now and also not compatible with Protractor's jasmine-like syntax. So, we have to also use `@types/jasminewd2` for e2e tests (but not for non-e2e tests). I also had to "augment" `@types/jasminewd2`, because the latest typings from [DefinitelyTyped][1] do not reflect the fact that the `jasminewd2` version (v2.1.0) currently used by Protractor supports passing a `done` callback to a spec. [1]: https://github.com/DefinitelyTyped/DefinitelyTyped/blob/566e0394859fdc1dc893658ccec6b06372d56a91/types/jasminewd2/index.d.ts#L9-L15 Fixes angular#23952 Closes angular#24733 PR Close angular#19904 test: make `NgMatchers` type-aware (angular#19904) PR Close angular#19904 refactor: infer type for `it()` assertion functions (angular#19904) PR Close angular#19904 build: upgrade jasmine to 2.99.x and fix tests (angular#19904) PR Close angular#19904 refactor: re-organize and "modernize" cjs-jasmine scripts (angular#19904) PR Close angular#19904 test: run unit tests in random order (angular#19904) PR Close angular#19904 build: upgrade jasmine to 3.1.0 (angular#19904) PR Close angular#19904 build: upgrade karma and related dependencies (angular#19904) PR Close angular#19904 docs: refactored ng-container code (angular#22742) PR Close angular#22742 docs: update Angular Boot Camp description (angular#23653) PR Close angular#23653 feat(service-worker): add support for `?` in SW config globbing (angular#24105) The globbing is used in the following sections: - `assetGroups` > `resources` > `files`/`versionedFiles` - `assetGroups` > `resources` > `urls` - `dataGroups` > `urls` - `navigationUrls` Query params are ignored for `files`/`versionedFiles` and `navigationUrls`, but they are still taken into account for `assetGroups`/`dataGroups` `urls`. To avoid a breaking change, `?` is matched literally for these patterns. PR Close angular#24105 refactor(service-worker): avoid unnecessary operations and remove unused code (angular#24127) PR Close angular#24127 fix(service-worker): avoid network requests when looking up hashed resources in cache (angular#24127) PR Close angular#24127 feat(ivy): properly apply style="", [style], [style.foo] and [attr.style] bindings (angular#24602) PR Close angular#24602 fix(language-service): do not overwrite native `Reflect` (angular#24299) Fixes angular#21420 PR Close angular#24299 fix(common): use correct currency format for locale de-AT (angular#24658) Fixes angular#24609 PR Close angular#24658 fix(ivy): correctly resolve Array property access (angular#24664) PR Close angular#24664 build: make `internal-angular` karma reporter compatible with latest karma (angular#24803) Due to changes in karma@1.0.0, `internal-angular` karma reporter stopped showing browser logs (such as `console.log()` etc.). Related to d571a51. PR Close angular#24803 build: remove unnecessary `internal-angular` karma reporter (angular#24803) The reporter was added in 87d56ac, with the purpose of fixing source-map paths (which was apparently needed back then). Things have moved around a lot since then and the custom reporter doesn't seem to be necessary any more. By removing the reporter, we have one less thing to worry about while upgrading karma; plus we get improvements in built-in reporters for free. Output with the custom reporter: ``` at someMethod (packages/core/.../some-file.ts:13:37) ``` Output with the built-in reporter: ``` at someMethod (packages/core/.../some-file.ts:13.37 <- dist/all/@angular/core/.../some-file.js:1:337) ``` PR Close angular#24803 fix(core): mark NgModule as not the root if APP_ROOT is set to false (angular#24814) Tree shakable providers use the APP_ROOT token to determine where to attach themselves. APP_ROOT gets set on NgModule with BrowserModule irrespective of whether it is actually the root(Ex. in case of SSR app where the shell app is first bootstrapped without BrowserModule being the root module). This change allows a NgModule with BrowserModule to explicitly mark itself as not the root by setting APP_ROOT token to false. This allows tree shakable providers to be attached to the right rott module. PR Close angular#24814 fix(platform-browser): mark Meta and Title services as tree shakable providers (angular#24815) This lets services that use Meta and Title services to be tree shakable and provided in root. PR Close angular#24815 docs(aio): unified console.log single string style (angular#22737) PR Close angular#22737 docs: unified console.log single string style (angular#22737) PR Close angular#22737 fix(compiler-cli): Use typescript to resolve modules for metadata (angular#22856) The current module resolution simply attaches .ts to the import/export path, which does not work if the path is using Node / CommonJS behavior to resolve to an index.ts file. This patch uses typescript's module resolution logic, and will attempt to load the original typescript file if this resolution returns a .js or .d.ts file PR Close angular#22856 docs: clarify wording in architecture overview (angular#24481) Closes angular#23463 Closes angular#22158 PR Close angular#24481 docs: add tree-shakable providers (angular#24481) PR Close angular#24481 fix(ivy): support projecting into dynamic views (angular#24752) PR Close angular#24752 refactor(ivy): replace pNextOrParent with TNode props (angular#24752) PR Close angular#24752 docs: fix typo in Universal guide (angular#24812) PR Close angular#24812 fix(platform-browser): workaround wrong import path generated by ngc for DOCUMENT (angular#24830) docs: correct project definition (angular#24807) PR Close angular#24807 build: update to latest nodejs bazel rules (angular#24817) PR Close angular#24817 fix(common): do not round factional seconds (angular#24831) fixes angular#24384 PR Close angular#24831 docs: fix typos referencing inline component styles (angular#22557) PR Close angular#22557 fix(router): add ability to recover from malformed url (angular#23283) Fixes angular#21468 PR Close angular#23283 docs: fix incorrect forms selector references (angular#22631) PR Close angular#22631 docs(aio): unified string chaining (angular#22735) PR Close angular#22735 docs: unified string chaining (angular#22735) PR Close angular#22735 docs(forms): added missing backtick (angular#24451) Fixed trivial markdown problem with a missing backtick. PR Close angular#24451 docs(forms): update API reference for form validators (angular#24734) PR Close angular#24734 Merge remote-tracking branch 'upstream/master' into refactor-example-pipe docs: refactor pipe example to use the HttpClient docs: refactor pipe example to use the HttpClient
danielsogl
added a commit
to danielsogl/angular
that referenced
this pull request
Jul 25, 2018
docs: fix typos in 'Httpclient' docs (angular#19127) PR Close angular#19127 docs(router): add `paramsInheritanceStrategy` documentation (angular#22590) PR Close angular#22590 docs: add app.module to changed documents (angular#23876) PR Close angular#23876 docs: clarify faqs about services (angular#24079) PR Close angular#24079 docs(aio): added a link to Angular Zero online course (Traditional Chinese) (angular#24228) PR Close angular#24228 docs: describe rounding behaviour of 'DecimalPipe' (angular#24303) PR Close angular#24303 docs(common): fix in the documentation of PUT (angular#24528) PR Close angular#24528 docs: add workspace and related cli terms (angular#24633) PR Close angular#24633 docs(changelog): correct inaccuracies (angular#24713) PR Close angular#24713 test: integration test for TS 2.9.x (angular#24749) PR Close angular#24749 fix(ivy): pipes are pure by default (angular#24750) PR Close angular#24750 build(bazel): update to rule_nodejs 0.10.0 (angular#24759) PR Close angular#24759 build: upgrade jasmine (and related typings) to latest version (angular#19904) With these changes, the types are a little stricter now and also not compatible with Protractor's jasmine-like syntax. So, we have to also use `@types/jasminewd2` for e2e tests (but not for non-e2e tests). I also had to "augment" `@types/jasminewd2`, because the latest typings from [DefinitelyTyped][1] do not reflect the fact that the `jasminewd2` version (v2.1.0) currently used by Protractor supports passing a `done` callback to a spec. [1]: https://github.com/DefinitelyTyped/DefinitelyTyped/blob/566e0394859fdc1dc893658ccec6b06372d56a91/types/jasminewd2/index.d.ts#L9-L15 Fixes angular#23952 Closes angular#24733 PR Close angular#19904 test: make `NgMatchers` type-aware (angular#19904) PR Close angular#19904 refactor: infer type for `it()` assertion functions (angular#19904) PR Close angular#19904 build: upgrade jasmine to 2.99.x and fix tests (angular#19904) PR Close angular#19904 refactor: re-organize and "modernize" cjs-jasmine scripts (angular#19904) PR Close angular#19904 test: run unit tests in random order (angular#19904) PR Close angular#19904 build: upgrade jasmine to 3.1.0 (angular#19904) PR Close angular#19904 build: upgrade karma and related dependencies (angular#19904) PR Close angular#19904 docs: refactored ng-container code (angular#22742) PR Close angular#22742 docs: update Angular Boot Camp description (angular#23653) PR Close angular#23653 feat(service-worker): add support for `?` in SW config globbing (angular#24105) The globbing is used in the following sections: - `assetGroups` > `resources` > `files`/`versionedFiles` - `assetGroups` > `resources` > `urls` - `dataGroups` > `urls` - `navigationUrls` Query params are ignored for `files`/`versionedFiles` and `navigationUrls`, but they are still taken into account for `assetGroups`/`dataGroups` `urls`. To avoid a breaking change, `?` is matched literally for these patterns. PR Close angular#24105 refactor(service-worker): avoid unnecessary operations and remove unused code (angular#24127) PR Close angular#24127 fix(service-worker): avoid network requests when looking up hashed resources in cache (angular#24127) PR Close angular#24127 feat(ivy): properly apply style="", [style], [style.foo] and [attr.style] bindings (angular#24602) PR Close angular#24602 fix(language-service): do not overwrite native `Reflect` (angular#24299) Fixes angular#21420 PR Close angular#24299 fix(common): use correct currency format for locale de-AT (angular#24658) Fixes angular#24609 PR Close angular#24658 fix(ivy): correctly resolve Array property access (angular#24664) PR Close angular#24664 build: make `internal-angular` karma reporter compatible with latest karma (angular#24803) Due to changes in karma@1.0.0, `internal-angular` karma reporter stopped showing browser logs (such as `console.log()` etc.). Related to d571a51. PR Close angular#24803 build: remove unnecessary `internal-angular` karma reporter (angular#24803) The reporter was added in 87d56ac, with the purpose of fixing source-map paths (which was apparently needed back then). Things have moved around a lot since then and the custom reporter doesn't seem to be necessary any more. By removing the reporter, we have one less thing to worry about while upgrading karma; plus we get improvements in built-in reporters for free. Output with the custom reporter: ``` at someMethod (packages/core/.../some-file.ts:13:37) ``` Output with the built-in reporter: ``` at someMethod (packages/core/.../some-file.ts:13.37 <- dist/all/@angular/core/.../some-file.js:1:337) ``` PR Close angular#24803 fix(core): mark NgModule as not the root if APP_ROOT is set to false (angular#24814) Tree shakable providers use the APP_ROOT token to determine where to attach themselves. APP_ROOT gets set on NgModule with BrowserModule irrespective of whether it is actually the root(Ex. in case of SSR app where the shell app is first bootstrapped without BrowserModule being the root module). This change allows a NgModule with BrowserModule to explicitly mark itself as not the root by setting APP_ROOT token to false. This allows tree shakable providers to be attached to the right rott module. PR Close angular#24814 fix(platform-browser): mark Meta and Title services as tree shakable providers (angular#24815) This lets services that use Meta and Title services to be tree shakable and provided in root. PR Close angular#24815 docs(aio): unified console.log single string style (angular#22737) PR Close angular#22737 docs: unified console.log single string style (angular#22737) PR Close angular#22737 fix(compiler-cli): Use typescript to resolve modules for metadata (angular#22856) The current module resolution simply attaches .ts to the import/export path, which does not work if the path is using Node / CommonJS behavior to resolve to an index.ts file. This patch uses typescript's module resolution logic, and will attempt to load the original typescript file if this resolution returns a .js or .d.ts file PR Close angular#22856 docs: clarify wording in architecture overview (angular#24481) Closes angular#23463 Closes angular#22158 PR Close angular#24481 docs: add tree-shakable providers (angular#24481) PR Close angular#24481 fix(ivy): support projecting into dynamic views (angular#24752) PR Close angular#24752 refactor(ivy): replace pNextOrParent with TNode props (angular#24752) PR Close angular#24752 docs: fix typo in Universal guide (angular#24812) PR Close angular#24812 fix(platform-browser): workaround wrong import path generated by ngc for DOCUMENT (angular#24830) docs: correct project definition (angular#24807) PR Close angular#24807 build: update to latest nodejs bazel rules (angular#24817) PR Close angular#24817 fix(common): do not round factional seconds (angular#24831) fixes angular#24384 PR Close angular#24831 docs: fix typos referencing inline component styles (angular#22557) PR Close angular#22557 fix(router): add ability to recover from malformed url (angular#23283) Fixes angular#21468 PR Close angular#23283 docs: fix incorrect forms selector references (angular#22631) PR Close angular#22631 docs(aio): unified string chaining (angular#22735) PR Close angular#22735 docs: unified string chaining (angular#22735) PR Close angular#22735 docs(forms): added missing backtick (angular#24451) Fixed trivial markdown problem with a missing backtick. PR Close angular#24451 docs(forms): update API reference for form validators (angular#24734) PR Close angular#24734 Merge remote-tracking branch 'upstream/master' into refactor-example-pipe docs: refactor pipe example to use the HttpClient docs: refactor pipe example to use the HttpClient docs: refactor pipe example to use the HttpClient
IgorMinar
pushed a commit
that referenced
this pull request
Jul 30, 2018
docs: fix typos in 'Httpclient' docs (#19127) PR Close #19127 docs(router): add `paramsInheritanceStrategy` documentation (#22590) PR Close #22590 docs: add app.module to changed documents (#23876) PR Close #23876 docs: clarify faqs about services (#24079) PR Close #24079 docs(aio): added a link to Angular Zero online course (Traditional Chinese) (#24228) PR Close #24228 docs: describe rounding behaviour of 'DecimalPipe' (#24303) PR Close #24303 docs(common): fix in the documentation of PUT (#24528) PR Close #24528 docs: add workspace and related cli terms (#24633) PR Close #24633 docs(changelog): correct inaccuracies (#24713) PR Close #24713 test: integration test for TS 2.9.x (#24749) PR Close #24749 fix(ivy): pipes are pure by default (#24750) PR Close #24750 build(bazel): update to rule_nodejs 0.10.0 (#24759) PR Close #24759 build: upgrade jasmine (and related typings) to latest version (#19904) With these changes, the types are a little stricter now and also not compatible with Protractor's jasmine-like syntax. So, we have to also use `@types/jasminewd2` for e2e tests (but not for non-e2e tests). I also had to "augment" `@types/jasminewd2`, because the latest typings from [DefinitelyTyped][1] do not reflect the fact that the `jasminewd2` version (v2.1.0) currently used by Protractor supports passing a `done` callback to a spec. [1]: https://github.com/DefinitelyTyped/DefinitelyTyped/blob/566e0394859fdc1dc893658ccec6b06372d56a91/types/jasminewd2/index.d.ts#L9-L15 Fixes #23952 Closes #24733 PR Close #19904 test: make `NgMatchers` type-aware (#19904) PR Close #19904 refactor: infer type for `it()` assertion functions (#19904) PR Close #19904 build: upgrade jasmine to 2.99.x and fix tests (#19904) PR Close #19904 refactor: re-organize and "modernize" cjs-jasmine scripts (#19904) PR Close #19904 test: run unit tests in random order (#19904) PR Close #19904 build: upgrade jasmine to 3.1.0 (#19904) PR Close #19904 build: upgrade karma and related dependencies (#19904) PR Close #19904 docs: refactored ng-container code (#22742) PR Close #22742 docs: update Angular Boot Camp description (#23653) PR Close #23653 feat(service-worker): add support for `?` in SW config globbing (#24105) The globbing is used in the following sections: - `assetGroups` > `resources` > `files`/`versionedFiles` - `assetGroups` > `resources` > `urls` - `dataGroups` > `urls` - `navigationUrls` Query params are ignored for `files`/`versionedFiles` and `navigationUrls`, but they are still taken into account for `assetGroups`/`dataGroups` `urls`. To avoid a breaking change, `?` is matched literally for these patterns. PR Close #24105 refactor(service-worker): avoid unnecessary operations and remove unused code (#24127) PR Close #24127 fix(service-worker): avoid network requests when looking up hashed resources in cache (#24127) PR Close #24127 feat(ivy): properly apply style="", [style], [style.foo] and [attr.style] bindings (#24602) PR Close #24602 fix(language-service): do not overwrite native `Reflect` (#24299) Fixes #21420 PR Close #24299 fix(common): use correct currency format for locale de-AT (#24658) Fixes #24609 PR Close #24658 fix(ivy): correctly resolve Array property access (#24664) PR Close #24664 build: make `internal-angular` karma reporter compatible with latest karma (#24803) Due to changes in karma@1.0.0, `internal-angular` karma reporter stopped showing browser logs (such as `console.log()` etc.). Related to d571a51. PR Close #24803 build: remove unnecessary `internal-angular` karma reporter (#24803) The reporter was added in 87d56ac, with the purpose of fixing source-map paths (which was apparently needed back then). Things have moved around a lot since then and the custom reporter doesn't seem to be necessary any more. By removing the reporter, we have one less thing to worry about while upgrading karma; plus we get improvements in built-in reporters for free. Output with the custom reporter: ``` at someMethod (packages/core/.../some-file.ts:13:37) ``` Output with the built-in reporter: ``` at someMethod (packages/core/.../some-file.ts:13.37 <- dist/all/@angular/core/.../some-file.js:1:337) ``` PR Close #24803 fix(core): mark NgModule as not the root if APP_ROOT is set to false (#24814) Tree shakable providers use the APP_ROOT token to determine where to attach themselves. APP_ROOT gets set on NgModule with BrowserModule irrespective of whether it is actually the root(Ex. in case of SSR app where the shell app is first bootstrapped without BrowserModule being the root module). This change allows a NgModule with BrowserModule to explicitly mark itself as not the root by setting APP_ROOT token to false. This allows tree shakable providers to be attached to the right rott module. PR Close #24814 fix(platform-browser): mark Meta and Title services as tree shakable providers (#24815) This lets services that use Meta and Title services to be tree shakable and provided in root. PR Close #24815 docs(aio): unified console.log single string style (#22737) PR Close #22737 docs: unified console.log single string style (#22737) PR Close #22737 fix(compiler-cli): Use typescript to resolve modules for metadata (#22856) The current module resolution simply attaches .ts to the import/export path, which does not work if the path is using Node / CommonJS behavior to resolve to an index.ts file. This patch uses typescript's module resolution logic, and will attempt to load the original typescript file if this resolution returns a .js or .d.ts file PR Close #22856 docs: clarify wording in architecture overview (#24481) Closes #23463 Closes #22158 PR Close #24481 docs: add tree-shakable providers (#24481) PR Close #24481 fix(ivy): support projecting into dynamic views (#24752) PR Close #24752 refactor(ivy): replace pNextOrParent with TNode props (#24752) PR Close #24752 docs: fix typo in Universal guide (#24812) PR Close #24812 fix(platform-browser): workaround wrong import path generated by ngc for DOCUMENT (#24830) docs: correct project definition (#24807) PR Close #24807 build: update to latest nodejs bazel rules (#24817) PR Close #24817 fix(common): do not round factional seconds (#24831) fixes #24384 PR Close #24831 docs: fix typos referencing inline component styles (#22557) PR Close #22557 fix(router): add ability to recover from malformed url (#23283) Fixes #21468 PR Close #23283 docs: fix incorrect forms selector references (#22631) PR Close #22631 docs(aio): unified string chaining (#22735) PR Close #22735 docs: unified string chaining (#22735) PR Close #22735 docs(forms): added missing backtick (#24451) Fixed trivial markdown problem with a missing backtick. PR Close #24451 docs(forms): update API reference for form validators (#24734) PR Close #24734 Merge remote-tracking branch 'upstream/master' into refactor-example-pipe docs: refactor pipe example to use the HttpClient docs: refactor pipe example to use the HttpClient docs: refactor pipe example to use the HttpClient PR Close #22741
IgorMinar
pushed a commit
that referenced
this pull request
Jul 30, 2018
docs: fix typos in 'Httpclient' docs (#19127) PR Close #19127 docs(router): add `paramsInheritanceStrategy` documentation (#22590) PR Close #22590 docs: add app.module to changed documents (#23876) PR Close #23876 docs: clarify faqs about services (#24079) PR Close #24079 docs(aio): added a link to Angular Zero online course (Traditional Chinese) (#24228) PR Close #24228 docs: describe rounding behaviour of 'DecimalPipe' (#24303) PR Close #24303 docs(common): fix in the documentation of PUT (#24528) PR Close #24528 docs: add workspace and related cli terms (#24633) PR Close #24633 docs(changelog): correct inaccuracies (#24713) PR Close #24713 test: integration test for TS 2.9.x (#24749) PR Close #24749 fix(ivy): pipes are pure by default (#24750) PR Close #24750 build(bazel): update to rule_nodejs 0.10.0 (#24759) PR Close #24759 build: upgrade jasmine (and related typings) to latest version (#19904) With these changes, the types are a little stricter now and also not compatible with Protractor's jasmine-like syntax. So, we have to also use `@types/jasminewd2` for e2e tests (but not for non-e2e tests). I also had to "augment" `@types/jasminewd2`, because the latest typings from [DefinitelyTyped][1] do not reflect the fact that the `jasminewd2` version (v2.1.0) currently used by Protractor supports passing a `done` callback to a spec. [1]: https://github.com/DefinitelyTyped/DefinitelyTyped/blob/566e0394859fdc1dc893658ccec6b06372d56a91/types/jasminewd2/index.d.ts#L9-L15 Fixes #23952 Closes #24733 PR Close #19904 test: make `NgMatchers` type-aware (#19904) PR Close #19904 refactor: infer type for `it()` assertion functions (#19904) PR Close #19904 build: upgrade jasmine to 2.99.x and fix tests (#19904) PR Close #19904 refactor: re-organize and "modernize" cjs-jasmine scripts (#19904) PR Close #19904 test: run unit tests in random order (#19904) PR Close #19904 build: upgrade jasmine to 3.1.0 (#19904) PR Close #19904 build: upgrade karma and related dependencies (#19904) PR Close #19904 docs: refactored ng-container code (#22742) PR Close #22742 docs: update Angular Boot Camp description (#23653) PR Close #23653 feat(service-worker): add support for `?` in SW config globbing (#24105) The globbing is used in the following sections: - `assetGroups` > `resources` > `files`/`versionedFiles` - `assetGroups` > `resources` > `urls` - `dataGroups` > `urls` - `navigationUrls` Query params are ignored for `files`/`versionedFiles` and `navigationUrls`, but they are still taken into account for `assetGroups`/`dataGroups` `urls`. To avoid a breaking change, `?` is matched literally for these patterns. PR Close #24105 refactor(service-worker): avoid unnecessary operations and remove unused code (#24127) PR Close #24127 fix(service-worker): avoid network requests when looking up hashed resources in cache (#24127) PR Close #24127 feat(ivy): properly apply style="", [style], [style.foo] and [attr.style] bindings (#24602) PR Close #24602 fix(language-service): do not overwrite native `Reflect` (#24299) Fixes #21420 PR Close #24299 fix(common): use correct currency format for locale de-AT (#24658) Fixes #24609 PR Close #24658 fix(ivy): correctly resolve Array property access (#24664) PR Close #24664 build: make `internal-angular` karma reporter compatible with latest karma (#24803) Due to changes in karma@1.0.0, `internal-angular` karma reporter stopped showing browser logs (such as `console.log()` etc.). Related to d571a51. PR Close #24803 build: remove unnecessary `internal-angular` karma reporter (#24803) The reporter was added in 87d56ac, with the purpose of fixing source-map paths (which was apparently needed back then). Things have moved around a lot since then and the custom reporter doesn't seem to be necessary any more. By removing the reporter, we have one less thing to worry about while upgrading karma; plus we get improvements in built-in reporters for free. Output with the custom reporter: ``` at someMethod (packages/core/.../some-file.ts:13:37) ``` Output with the built-in reporter: ``` at someMethod (packages/core/.../some-file.ts:13.37 <- dist/all/@angular/core/.../some-file.js:1:337) ``` PR Close #24803 fix(core): mark NgModule as not the root if APP_ROOT is set to false (#24814) Tree shakable providers use the APP_ROOT token to determine where to attach themselves. APP_ROOT gets set on NgModule with BrowserModule irrespective of whether it is actually the root(Ex. in case of SSR app where the shell app is first bootstrapped without BrowserModule being the root module). This change allows a NgModule with BrowserModule to explicitly mark itself as not the root by setting APP_ROOT token to false. This allows tree shakable providers to be attached to the right rott module. PR Close #24814 fix(platform-browser): mark Meta and Title services as tree shakable providers (#24815) This lets services that use Meta and Title services to be tree shakable and provided in root. PR Close #24815 docs(aio): unified console.log single string style (#22737) PR Close #22737 docs: unified console.log single string style (#22737) PR Close #22737 fix(compiler-cli): Use typescript to resolve modules for metadata (#22856) The current module resolution simply attaches .ts to the import/export path, which does not work if the path is using Node / CommonJS behavior to resolve to an index.ts file. This patch uses typescript's module resolution logic, and will attempt to load the original typescript file if this resolution returns a .js or .d.ts file PR Close #22856 docs: clarify wording in architecture overview (#24481) Closes #23463 Closes #22158 PR Close #24481 docs: add tree-shakable providers (#24481) PR Close #24481 fix(ivy): support projecting into dynamic views (#24752) PR Close #24752 refactor(ivy): replace pNextOrParent with TNode props (#24752) PR Close #24752 docs: fix typo in Universal guide (#24812) PR Close #24812 fix(platform-browser): workaround wrong import path generated by ngc for DOCUMENT (#24830) docs: correct project definition (#24807) PR Close #24807 build: update to latest nodejs bazel rules (#24817) PR Close #24817 fix(common): do not round factional seconds (#24831) fixes #24384 PR Close #24831 docs: fix typos referencing inline component styles (#22557) PR Close #22557 fix(router): add ability to recover from malformed url (#23283) Fixes #21468 PR Close #23283 docs: fix incorrect forms selector references (#22631) PR Close #22631 docs(aio): unified string chaining (#22735) PR Close #22735 docs: unified string chaining (#22735) PR Close #22735 docs(forms): added missing backtick (#24451) Fixed trivial markdown problem with a missing backtick. PR Close #24451 docs(forms): update API reference for form validators (#24734) PR Close #24734 Merge remote-tracking branch 'upstream/master' into refactor-example-pipe docs: refactor pipe example to use the HttpClient docs: refactor pipe example to use the HttpClient docs: refactor pipe example to use the HttpClient PR Close #22741
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
action: merge
The PR is ready for merge by the caretaker
area: i18n
cla: yes
target: patch
This PR is targeted for the next patch release
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #24384