Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add HttpClientModule import code to services tutorial #24854

Closed
wants to merge 1 commit into from

Conversation

Ana06
Copy link
Contributor

@Ana06 Ana06 commented Jul 12, 2018

To be able to copy and paste, lazy people will thank it 😉

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[X] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@mary-poppins
Copy link

@jenniferfell jenniferfell added state: community Someone from the Angular community is working on this issue or submitted this PR and removed state: community Someone from the Angular community is working on this issue or submitted this PR labels Jul 23, 2018
@brandonroberts
Copy link
Contributor

@Ana06 if you're still interested in landing this PR, you'll need to sign the CLA and amend the commit message to be docs: add HttpClientModule import code to services tutorial

@brandonroberts brandonroberts self-assigned this Jul 31, 2018
@brandonroberts brandonroberts added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews target: patch This PR is targeted for the next patch release labels Jul 31, 2018
@googlebot
Copy link

CLAs look good, thanks!

@Ana06
Copy link
Contributor Author

Ana06 commented Aug 12, 2018

@brandonroberts done!

@mary-poppins
Copy link

You can preview 41b6616 at https://pr24854-41b6616.ngbuilds.io/.

@brandonroberts brandonroberts changed the title Documentation: Add HTTP import code to toh-pt6 docs: add HttpClientModule import code to services tutorial Aug 13, 2018
@mary-poppins
Copy link

You can preview 57b5653 at https://pr24854-57b5653.ngbuilds.io/.

@brandonroberts brandonroberts removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Aug 13, 2018
@brandonroberts brandonroberts added the action: review The PR is still awaiting reviews from at least one requested reviewer label Aug 13, 2018
@brandonroberts brandonroberts removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Aug 16, 2018
@brandonroberts brandonroberts added the action: merge The PR is ready for merge by the caretaker label Aug 16, 2018
@jasonaden jasonaden closed this in cc55d60 Aug 16, 2018
jasonaden pushed a commit that referenced this pull request Aug 16, 2018
FrederikSchlemmer pushed a commit to FrederikSchlemmer/angular that referenced this pull request Jan 3, 2019
@Ana06 Ana06 deleted the http-import branch April 30, 2019 14:04
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker aio: preview cla: yes state: community Someone from the Angular community is working on this issue or submitted this PR target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants