Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): remove withBody from public testing API #25171

Closed
wants to merge 2 commits into from

Conversation

mhevery
Copy link
Contributor

@mhevery mhevery commented Jul 27, 2018

No description provided.

@mhevery mhevery added the target: patch This PR is targeted for the next patch release label Jul 27, 2018
@mhevery mhevery requested a review from IgorMinar July 27, 2018 21:01
@mary-poppins
Copy link

You can preview 8d497d5 at https://pr25171-8d497d5.ngbuilds.io/.

@mary-poppins
Copy link

You can preview db77353 at https://pr25171-db77353.ngbuilds.io/.

@mhevery
Copy link
Contributor Author

mhevery commented Jul 27, 2018

@mary-poppins
Copy link

You can preview b5bb1cc at https://pr25171-b5bb1cc.ngbuilds.io/.

@IgorMinar IgorMinar added the action: merge The PR is ready for merge by the caretaker label Jul 31, 2018
@ngbot
Copy link

ngbot bot commented Jul 31, 2018

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure status "continuous-integration/travis-ci/pr" is failing
    pending status "google3" is pending

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@IgorMinar IgorMinar closed this in 6e2a187 Jul 31, 2018
FrederikSchlemmer pushed a commit to FrederikSchlemmer/angular that referenced this pull request Jan 3, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants