fix(core): size regression with closure compiler #25531
Conversation
| @@ -57,7 +57,13 @@ const IDENT_EVENT_IDX = 10; | |||
| const TEMPLATE_ATTR_PREFIX = '*'; | |||
| const CLASS_ATTR = 'class'; | |||
|
|
|||
| const TEXT_CSS_SELECTOR = CssSelector.parse('*')[0]; | |||
| let _TEXT_CSS_SELECTOR !: CssSelector; | |||
There was a problem hiding this comment.
Why is there no corresponding change on the usage site to call TEXT_CSS_SELCTOR as a function?
By pulling in `compiler` into `core` the `compiler` was not 100% tree-shakable and about 8KB of code was retained when tree-shaken with closure.
mhevery
force-pushed
the
size_regression
branch
from
48b581d
to
537424f
Compare
|
You can preview 537424f at https://pr25531-537424f.ngbuilds.io/. |
|
I see that you just added the If you want your PR to be merged, it has to pass all the CI checks. If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help. |
By pulling in `compiler` into `core` the `compiler` was not 100% tree-shakable and about 8KB of code was retained when tree-shaken with closure. PR Close #25531
By pulling in `compiler` into `core` the `compiler` was not 100% tree-shakable and about 8KB of code was retained when tree-shaken with closure. PR Close angular#25531
By pulling in `compiler` into `core` the `compiler` was not 100% tree-shakable and about 8KB of code was retained when tree-shaken with closure. PR Close angular#25531
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
By pulling in
compilerintocorethecompilerwas not100% tree-shakable and about 8KB of code was retained
when tree-shaken with closure.