Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ngcc: implement ivy switch rendering #25534

Closed
wants to merge 6 commits into from
Closed

ngcc: implement ivy switch rendering #25534

wants to merge 6 commits into from

Commits on Aug 28, 2018

  1. feat(ivy): implement NgccReflectionHost.getSwitchableDeclarations() 

    This method will be used to find all the places where the "ivy switch"
will occur. See angular#25238
    @petebacondarwin
    petebacondarwin committed Aug 28, 2018
    Configuration menu
    Copy the full SHA
    a5173e8 View commit details
    Browse the repository at this point in the history

  2. test(ivy): refactor Esm2015Renderer tests to make them less fragile

    @petebacondarwin
    petebacondarwin committed Aug 28, 2018
    Configuration menu
    Copy the full SHA
    3b7df99 View commit details
    Browse the repository at this point in the history

  3. test(ivy): refactor Esm5Renderer tests to make them less fragile

    @petebacondarwin
    petebacondarwin committed Aug 28, 2018
    Configuration menu
    Copy the full SHA
    4a51bb1 View commit details
    Browse the repository at this point in the history

  4. feat(ivy): implement Renderer.getSwitchableDeclarations 

    This supports the "ngcc ivy switch" specified in angular#25238.
    @petebacondarwin
    petebacondarwin committed Aug 28, 2018
    Configuration menu
    Copy the full SHA
    9a0c285 View commit details
    Browse the repository at this point in the history

  5. test(ivy): test Esm5Renderer.getSwitchableDeclarations 

    Also incorporates a refactoring of the tests to make them less fragile.
    @petebacondarwin
    petebacondarwin committed Aug 28, 2018
    Configuration menu
    Copy the full SHA
    a5f679f View commit details
    Browse the repository at this point in the history

  6. perf(ivy): speed up ngcc ivy switch processing 

    Only parse the AST for ngcc ivy switch constants
if the marker is not found in the module text.
    @petebacondarwin
    petebacondarwin committed Aug 28, 2018
    Configuration menu
    Copy the full SHA
    29457cc View commit details
    Browse the repository at this point in the history