refactor(ivy): replace LNode.dynamicLContainerNode with flat LContainers

[kara]

Previously, nodes with containers were stored flat in LViewData, so it was necessary to read LNode.data to reach the LContainer instance. This PR inverts this relationship, so we are now storing LContainer instances flat in LViewData, with LContainer[HOST_NATIVE] storing the host nodes. This allows us to remove LNode.dynamicLContainerNode and TNode.dynamicContainerNode, and is the first step toward removing LNode.data.

Still TODO:

• Invert LNode.data for component and view nodes
• Remove LNode.native

[mary-poppins]

You can preview 60f778d at https://pr26407-60f778d.ngbuilds.io/.

[mhevery]

I find this format more readable, would you mind changing it:

  if (Array.isArray(value)) {
    if (typeof value[ACTIVE_INDEX] === 'number') {
      // This is an LContainer. It may also have a styling context.
      value = value[HOST_NATIVE] as LElementNode | StylingContext;
      return Array.isArray(value) ? value[StylingIndex.ElementPosition] ! : value;
    } else {
      // This is a StylingContext, which stores the element node at 0.
      return value[StylingIndex.ElementPosition] as LElementNode;
    }
  } else {
    return value;  // Regular LNode is stored here
  }

• Early returns confuse me.
• Not clear that value is array after the guard.

[mary-poppins]

You can preview 085efa4 at https://pr26407-085efa4.ngbuilds.io/.

[mary-poppins]

You can preview d979871 at https://pr26407-d979871.ngbuilds.io/.

[kara]

presubmit

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}