fix(router): remove type bludgeoning of context and outlet when running CanDeactivate #26496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng CanDeactivate Fixes angular#18253
|
You can preview b772d3e at https://pr26496-b772d3e.ngbuilds.io/. |
|
Looking forward to get this merged! |
jasonaden
added
action: merge
benlesh
approved these changes
Oct 30, 2018
sculove
pushed a commit
to sculove/angular
that referenced
this pull request
Nov 2, 2018
…ng CanDeactivate (angular#26496) Fixes angular#18253 PR Close angular#26496
andrewfolga
pushed a commit
to hmcts/ccd-case-ui-toolkit
that referenced
this pull request
Nov 12, 2018
andrewfolga
pushed a commit
to hmcts/ccd-case-management-web
that referenced
this pull request
Nov 12, 2018
noronhaa
added a commit
to hmcts/ccd-case-ui-toolkit
that referenced
this pull request
Nov 12, 2018
Rdm 3230 RDM-3230 Up version of angular to fix Router bug angular/angular#26496
andrewfolga
pushed a commit
to hmcts/ccd-case-ui-toolkit
that referenced
this pull request
Nov 12, 2018
noronhaa
pushed a commit
to hmcts/ccd-case-ui-toolkit
that referenced
this pull request
Nov 12, 2018
noronhaa
pushed a commit
to hmcts/ccd-case-management-web
that referenced
this pull request
Nov 12, 2018
* RDM-3064 Initial changes to migrate services to UI toolkit as part of creating new create and edit case facade components there. * RDM-3064 Facilitate configuration of case progression component * RDM-3064_to_merge Add CaseCreateComponet and CaseProgressComponent to CasesModule. * RDM-3064_to_merge Remove unused components added by mistake. * RDM-3230 Directory structure changes plus renaming. * RDM-3230 Add DialogsModule in imports of SharedModule. * RDM-3230 Up version of angular to fix Router bug angular/angular#26496 * RDM-3230 Upgrade ui toolkit to 2.4.0
mohammedanas
added a commit
to hmcts/ccd-case-ui-toolkit
that referenced
this pull request
Nov 14, 2018
* master: (69 commits) RDM-3230 Release new 2.4.0 version - Up version of angular to fix Router bug angular/angular#26496 (#137) RDM-3230 Remove debug console logging and comments. RDM-3230 Up version of angular to fix Router bug angular/angular#26496 RDM-3230 Relax versions in engines. RDM-3230 Relax engines for yarn and npm. RDM-3230 Update README. RDM-3230 Heroku Badge. RDM-3230 Push different heroku badge icon. RDM-3230 Release 2.2.0 RDM-3230 Add badge. Improve shell script. RDM-3230 Update README RDM-3230 Simplify heroku script and update README. RDM-3230 Fix Heroku and improve build steps in package.json. RDM-3230 Replace copyfiles with cp RDM-3230 Swap build of lib with install of demo app. RDM-3230 Create dir for heroku before copying dist. RDM-3230 Fix heroku - use heroku-postbuild instead of postinstall RDM-3230 Downgrade yarn in travis CI. RDM-3230 Downgrade yarn. RDM-3230 Obfuscate gateway api urls. ... # Conflicts: # src/shared/components/palette/palette.module.ts
mohammedanas
added a commit
to hmcts/ccd-case-ui-toolkit
that referenced
this pull request
Nov 14, 2018
* master: RDM-3230 Release new 2.4.0 version - Up version of angular to fix Router bug angular/angular#26496 (#137) RDM-3230 Remove debug console logging and comments. RDM-3230 Up version of angular to fix Router bug angular/angular#26496 RDM-3230 Relax versions in engines. RDM-3230 Relax engines for yarn and npm. RDM-3230 Update README. RDM-3230 Heroku Badge. RDM-3230 Push different heroku badge icon. RDM-3230 Release 2.2.0 RDM-3230 Add badge. Improve shell script. RDM-3230 Update README RDM-3230 Simplify heroku script and update README. RDM-3230 Fix Heroku and improve build steps in package.json. RDM-3230 Replace copyfiles with cp RDM-3230 Swap build of lib with install of demo app. RDM-3230 Create dir for heroku before copying dist. RDM-3230 Fix heroku - use heroku-postbuild instead of postinstall RDM-3230 Downgrade yarn in travis CI. RDM-3230 Downgrade yarn.
mohammedanas
added a commit
to hmcts/ccd-case-ui-toolkit
that referenced
this pull request
Nov 16, 2018
…i-toolkit into RDM-1893-FixedRadioList * 'RDM-1893-FixedRadioList' of github.com:hmcts/ccd-case-ui-toolkit: RDM-3230 Small patch to export profile service. RDM-3230 Export ProfileService. Update package.json Update Release notes for v2.5.0 [PREVIEW] RDM-3000 MidEvent callback. Fix updateFormData method. [PREVIEW] RDM-3000 MidEvent callback. Fix Continue button name. [PREVIEW] RDM-3000 MidEvent callback RDM-3230 Release new 2.4.0 version - Up version of angular to fix Router bug angular/angular#26496
mohammedanas
added a commit
to hmcts/ccd-case-management-web
that referenced
this pull request
Nov 16, 2018
* master: (46 commits) RDM-3230 Remove profile service and import from ui toolkit. change smoke test run format to old original smoke tests [PREVIEW] RDM-3000 update yarn.lock Update UI-Toolkit Version to v2.5.1 Functional test updates (#397) Fix disappearing dependency Sync yarn.lock with package.json [PREVIEW] RDM-3000 MidEvent callback RDM-3230 Upgrade yarn to 1.9.2 for Travis CI. RDM-3230 Upping ui toolkit version. RDM-3230 Attempt to fix the build. RDM-3230 Yarn update to 1.12.1 RDM-3064_to_merge Replace with MockComponent. RDM-3064_to_merge Remove empty char. RDM-3064 Trigger PREVIEW deployment. RDM-3230 Upgrade ui toolkit to 2.4.0 RDM-3230 Up version of angular to fix Router bug angular/angular#26496 RDM-3230 Fix test. RDM-3230 Relax versions for engines. RDM-3230 Add range to engines for yarn. ...
FrederikSchlemmer
pushed a commit
to FrederikSchlemmer/angular
that referenced
this pull request
Jan 3, 2019
…ng CanDeactivate (angular#26496) Fixes angular#18253 PR Close angular#26496
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18253
Based on #19374
This PR doesn't have associated tests because it should have been a type failure from the beginning. We had used
!to tell TS these objects couldn't be null when they clearly can. Existing tests continue to work, which should be the requirement to fix this issue.