Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: update canonical-path dependency #26719

Closed
wants to merge 1 commit into from
Closed

build: update canonical-path dependency #26719

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion aio/package.json
View file
Open in desktop
Expand Up @@ -104,7 +104,7 @@
"@types/jasminewd2": "^2.0.4",
"@types/node": "~6.0.60",
"archiver": "^1.3.0",
"canonical-path": "^0.0.2",
"canonical-path": "1.0.0",
"chalk": "^2.1.0",
"cjson": "^0.5.0",
"codelyzer": "~4.2.1",
Expand Down
2 changes: 1 addition & 1 deletion aio/tools/examples/shared/package.json
View file
Open in desktop
Expand Up @@ -57,7 +57,7 @@
"@types/jasminewd2": "^2.0.4",
"@types/jquery": "^3.3.4",
"@types/node": "~8.9.4",
"canonical-path": "0.0.2",
"canonical-path": "1.0.0",
"concurrently": "^3.0.0",
"http-server": "^0.9.0",
"jasmine-core": "~2.99.1",
Expand Down
5 changes: 5 additions & 0 deletions aio/tools/examples/shared/yarn.lock
View file
Open in desktop
Expand Up @@ -1450,6 +1450,11 @@ canonical-path@0.0.2:
version "0.0.2"
resolved "https://registry.yarnpkg.com/canonical-path/-/canonical-path-0.0.2.tgz#e31eb937a8c93ee2a01df1839794721902874574"

canonical-path@1.0.0:
version "1.0.0"
resolved "https://registry.yarnpkg.com/canonical-path/-/canonical-path-1.0.0.tgz#fcb470c23958def85081856be7a86e904f180d1d"
integrity sha512-feylzsbDxi1gPZ1IjystzIQZagYYLvfKrSuygUCgf7z6x790VEzze5QEkdSV1U58RA7Hi0+v6fv4K54atOzATg==

caseless@~0.12.0:
version "0.12.0"
resolved "https://registry.yarnpkg.com/caseless/-/caseless-0.12.0.tgz#1b681c21ff84033c826543090689420d187151dc"
Expand Down
7 changes: 6 additions & 1 deletion aio/yarn.lock
View file
Open in desktop
Expand Up @@ -1746,11 +1746,16 @@ caniuse-lite@^1.0.30000832, caniuse-lite@^1.0.30000844:
resolved "https://registry.yarnpkg.com/caniuse-lite/-/caniuse-lite-1.0.30000890.tgz#86a18ffcc65d79ec6a437e985761b8bf1c4efeaf"
integrity sha512-4NI3s4Y6ROm+SgZN5sLUG4k7nVWQnedis3c/RWkynV5G6cHSY7+a8fwFyn2yoBDE3E6VswhTNNwR3PvzGqlTkg==

canonical-path@0.0.2, canonical-path@^0.0.2, canonical-path@~0.0.2:
canonical-path@0.0.2, canonical-path@~0.0.2:
version "0.0.2"
resolved "https://registry.yarnpkg.com/canonical-path/-/canonical-path-0.0.2.tgz#e31eb937a8c93ee2a01df1839794721902874574"
integrity sha1-4x65N6jJPuKgHfGDl5RyGQKHRXQ=

canonical-path@1.0.0:
version "1.0.0"
resolved "https://registry.yarnpkg.com/canonical-path/-/canonical-path-1.0.0.tgz#fcb470c23958def85081856be7a86e904f180d1d"
integrity sha512-feylzsbDxi1gPZ1IjystzIQZagYYLvfKrSuygUCgf7z6x790VEzze5QEkdSV1U58RA7Hi0+v6fv4K54atOzATg==

capture-stack-trace@^1.0.0:
version "1.0.0"
resolved "https://registry.yarnpkg.com/capture-stack-trace/-/capture-stack-trace-1.0.0.tgz#4a6fa07399c26bba47f0b2496b4d0fb408c5550d"
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Expand Up @@ -57,7 +57,7 @@
"angular-mocks-1.5": "npm:angular-mocks@1.5",
"angular-mocks-1.6": "npm:angular-mocks@1.6",
"base64-js": "1.2.1",
"canonical-path": "0.0.2",
"canonical-path": "1.0.0",
"chokidar": "1.7.0",
"convert-source-map": "^1.5.1",
"dependency-graph": "^0.7.2",
Expand Down
2 changes: 1 addition & 1 deletion packages/compiler-cli/package.json
View file
Open in desktop
Expand Up @@ -12,7 +12,7 @@
"dependencies": {
"reflect-metadata": "^0.1.2",
"minimist": "^1.2.0",
"canonical-path": "0.0.2",
"canonical-path": "1.0.0",
"chokidar": "^1.4.2",
"convert-source-map": "^1.5.1",
"dependency-graph": "^0.7.2",
Expand Down
1 change: 1 addition & 0 deletions packages/compiler-cli/src/ngcc/BUILD.bazel
View file
Open in desktop
Expand Up @@ -22,6 +22,7 @@ ts_library(
"@ngdeps//@types/shelljs",
"@ngdeps//@types/source-map",
"@ngdeps//@types/yargs",
"@ngdeps//canonical-path",
"@ngdeps//dependency-graph",
"@ngdeps//magic-string",
"@ngdeps//source-map",
Expand Down
14 changes: 0 additions & 14 deletions packages/compiler-cli/src/ngcc/canonical-path.d.ts
View file
Open in desktop

This file was deleted.

1 change: 1 addition & 0 deletions packages/compiler-cli/src/ngcc/test/BUILD.bazel
View file
Open in desktop
Expand Up @@ -15,6 +15,7 @@ ts_library(
"//packages/compiler-cli/src/ngtsc/transform",
"@ngdeps//@types/convert-source-map",
"@ngdeps//@types/mock-fs",
"@ngdeps//canonical-path",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't it odd that we needed to add this dep now? why now?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@IgorMinar - I believe that this is because, previously, the library did not contain any typings, so the build didn't care bout it as a dependency. Now that I have removed the local typings file and rely upon the typings in the library it is needed.

"@ngdeps//magic-string",
"@ngdeps//typescript",
],
Expand Down
8 changes: 4 additions & 4 deletions yarn.lock
View file
Open in desktop
Expand Up @@ -1274,10 +1274,10 @@ camelcase@^4.1.0:
resolved "https://registry.yarnpkg.com/camelcase/-/camelcase-4.1.0.tgz#d545635be1e33c542649c69173e5de6acfae34dd"
integrity sha1-1UVjW+HjPFQmScaRc+Xeas+uNN0=

canonical-path@0.0.2:
version "0.0.2"
resolved "https://registry.yarnpkg.com/canonical-path/-/canonical-path-0.0.2.tgz#e31eb937a8c93ee2a01df1839794721902874574"
integrity sha1-4x65N6jJPuKgHfGDl5RyGQKHRXQ=
canonical-path@1.0.0:
version "1.0.0"
resolved "https://registry.yarnpkg.com/canonical-path/-/canonical-path-1.0.0.tgz#fcb470c23958def85081856be7a86e904f180d1d"
integrity sha512-feylzsbDxi1gPZ1IjystzIQZagYYLvfKrSuygUCgf7z6x790VEzze5QEkdSV1U58RA7Hi0+v6fv4K54atOzATg==

caseless@~0.11.0:
version "0.11.0"
Expand Down