Add schematic details and links to config page #27272

jbogarthyde · 2018-11-26T18:22:02Z

PR Checklist

Please check if your PR fulfills the following requirements:

The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

Bugfix
Feature
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Documentation content changes
angular.io application / infrastructure changes
Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

Yes
No

Other information

mary-poppins · 2018-11-27T18:20:02Z

You can preview 0337411 at https://pr27272-0337411.ngbuilds.io/.

alan-agius4 · 2018-11-27T19:00:22Z

aio/content/guide/workspace-config.md

+The JSON schemas for the default schematics used by the CLI to generate project components are collected in the [`@schematics` package](https://github.com/angular/angular-cli/blob/v6.0.0-rc.8/packages/%40angular/cli/lib/config/schema.json).
+These schematics configure the options available to the CLI for generating the following `ng generate` sub-commands:
+
+* [component](https://github.com/angular/angular-cli/blob/v6.0.0-rc.8/packages/%40angular/cli/lib/config/schema.json#L74-L144)


I don't think we should use tags here, at least not for version 6.

But what should we use instead, thoughts?

//cc @hansl

The tag is fine. I don't think we should use RC tags, only stable ones.

Is there a reason this points to 6.0 instead of 7?

Removed individual links and added description of how you could use the workspace schema.
@hansl please check.

aio/content/guide/workspace-config.md

mary-poppins · 2018-11-27T19:32:40Z

You can preview 7d04ba3 at https://pr27272-7d04ba3.ngbuilds.io/.

mary-poppins · 2018-11-27T19:36:01Z

You can preview 29427dd at https://pr27272-29427dd.ngbuilds.io/.

mary-poppins · 2018-11-27T19:42:54Z

You can preview c2a61d9 at https://pr27272-c2a61d9.ngbuilds.io/.

mary-poppins · 2018-11-27T23:26:14Z

You can preview c24f728 at https://pr27272-c24f728.ngbuilds.io/.

mary-poppins · 2018-11-30T16:19:21Z

You can preview 5810a3c at https://pr27272-5810a3c.ngbuilds.io/.

mary-poppins · 2018-12-03T17:13:56Z

You can preview 1274cbf at https://pr27272-1274cbf.ngbuilds.io/.

mary-poppins · 2019-03-14T18:16:14Z

You can preview c7487ee at https://pr27272-c7487ee.ngbuilds.io/.

mary-poppins · 2019-03-19T15:41:30Z

You can preview 79db1d6 at https://pr27272-79db1d6.ngbuilds.io/.

mary-poppins · 2019-03-20T16:17:08Z

You can preview ea07cf7 at https://pr27272-ea07cf7.ngbuilds.io/.

Splaktar

There still seems to be some confusion here between Schematics and Architect that needs to be resolved. There are also some minor suggested improvements.

aio/content/guide/workspace-config.md

jbogarthyde · 2019-03-25T16:19:39Z

Thanks @Splaktar -- corrections made.

mary-poppins · 2019-03-25T16:23:08Z

You can preview c504609 at https://pr27272-c504609.ngbuilds.io/.

mary-poppins · 2019-03-25T16:24:28Z

You can preview 54b6e63 at https://pr27272-54b6e63.ngbuilds.io/.

Splaktar

Some additional suggestions.

Splaktar · 2019-03-26T09:34:07Z

aio/content/guide/workspace-config.md

-At the top level of `angular.json`, a few properties configure the workspace, and a `projects` section contains the remaining per-project configuration options.
+At the top level of `angular.json`, a few properties configure the workspace, and a `projects` section contains the remaining per-project configuration options. CLI defaults set at the workspace level can be overridden by defaults set at the project level, and defaults set at the project level can be overridden on the command line.
+
+The following properties at the top level of the file configure the workspace.


Suggested change

The following properties at the top level of the file configure the workspace.

The following are properties at the top level of the workspace configuration file:

aio/content/guide/workspace-config.md

mary-poppins · 2019-03-26T15:34:04Z

You can preview 323792a at https://pr27272-323792a.ngbuilds.io/.

mary-poppins · 2019-03-26T16:56:02Z

You can preview e24620e at https://pr27272-e24620e.ngbuilds.io/.

Splaktar · 2019-03-26T18:34:54Z

aio/content/guide/workspace-config.md

-At the top level of `angular.json`, a few properties configure the workspace, and a `projects` section contains the remaining per-project configuration options.
+At the top level of `angular.json`, a few properties configure the workspace, and a `projects` section contains the remaining per-project configuration options. CLI defaults set at the workspace level can be overridden by defaults set at the project level, and defaults set at the project level can be overridden on the command line.
+
+The following properties are at the top level of the file configure the workspace.


My whole suggestion was not accepted for this line. It still has some grammar issues even after that update.

Oops, fixing typo. This line introduces the list of top-level properties:
"The following properties at the top level of the file configure the workspace."
What do you think is wrong with it?

Oh I think that I see how you want it to read... perhaps this would make that more clear to the reader:
"The following properties, at the top level of the file, configure the workspace."

You're right. Done.

mary-poppins · 2019-03-26T19:51:05Z

You can preview 7dbbc48 at https://pr27272-7dbbc48.ngbuilds.io/.

mary-poppins · 2019-03-26T20:44:49Z

You can preview 58ff57f at https://pr27272-58ff57f.ngbuilds.io/.

Splaktar

LGTM

mary-poppins · 2019-03-27T16:33:46Z

You can preview b6ce9a6 at https://pr27272-b6ce9a6.ngbuilds.io/.

mary-poppins · 2019-03-27T16:36:22Z

You can preview 4adefc8 at https://pr27272-4adefc8.ngbuilds.io/.

PR Close angular#27272

angular-automatic-lock-bot · 2019-09-14T21:52:13Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

googlebot added the cla: yes label Nov 26, 2018

jbogarthyde added type: bug/fix comp: docs target: patch This PR is targeted for the next patch release labels Nov 26, 2018

ngbot bot modified the milestone: needsTriage Nov 26, 2018

jbogarthyde force-pushed the jb-config-schematics branch from 9ef982a to 959d154 Compare November 27, 2018 16:43

alan-agius4 reviewed Nov 27, 2018

View reviewed changes

aio/content/guide/workspace-config.md Outdated Show resolved Hide resolved

jbogarthyde force-pushed the jb-config-schematics branch 3 times, most recently from a71d388 to a0a2f7f Compare November 29, 2018 16:35

jenniferfell added feature Issue that requests a new feature effort2: days risk: medium and removed feature Issue that requests a new feature labels Nov 29, 2018

ngbot bot modified the milestones: needsTriage, Backlog Nov 29, 2018

jbogarthyde force-pushed the jb-config-schematics branch from a0a2f7f to 5810a3c Compare November 30, 2018 16:09

jbogarthyde force-pushed the jb-config-schematics branch from 5810a3c to 1274cbf Compare December 3, 2018 17:06

jbogarthyde force-pushed the jb-config-schematics branch from c7487ee to 79db1d6 Compare March 19, 2019 15:36

jbogarthyde force-pushed the jb-config-schematics branch from 79db1d6 to ea07cf7 Compare March 20, 2019 16:11

Splaktar suggested changes Mar 25, 2019

View reviewed changes

jbogarthyde force-pushed the jb-config-schematics branch from ea07cf7 to 7e06662 Compare March 25, 2019 15:48

Splaktar suggested changes Mar 26, 2019

View reviewed changes

jbogarthyde force-pushed the jb-config-schematics branch from 323792a to e24620e Compare March 26, 2019 16:51

Splaktar suggested changes Mar 26, 2019

View reviewed changes

Splaktar approved these changes Mar 26, 2019

View reviewed changes

jbogarthyde added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Mar 27, 2019

jbogarthyde force-pushed the jb-config-schematics branch from 58ff57f to b6ce9a6 Compare March 27, 2019 16:28

docs: add schematic details and links to config page

4adefc8

jbogarthyde force-pushed the jb-config-schematics branch from b6ce9a6 to 4adefc8 Compare March 27, 2019 16:31

mhevery closed this in f8c7c3c Mar 27, 2019

jbogarthyde deleted the jb-config-schematics branch March 28, 2019 15:46

wKoza pushed a commit to wKoza/angular that referenced this pull request Apr 17, 2019

docs: add schematic details and links to config page (angular#27272)

8d76055

PR Close angular#27272

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add schematic details and links to config page #27272

Add schematic details and links to config page #27272

jbogarthyde commented Nov 26, 2018

mary-poppins commented Nov 27, 2018

alan-agius4 Nov 27, 2018

hansl Dec 14, 2018

jbogarthyde Dec 14, 2018 •

edited

mary-poppins commented Nov 27, 2018

mary-poppins commented Nov 27, 2018

mary-poppins commented Nov 27, 2018

mary-poppins commented Nov 27, 2018

mary-poppins commented Nov 30, 2018

mary-poppins commented Dec 3, 2018

mary-poppins commented Mar 14, 2019

mary-poppins commented Mar 19, 2019

mary-poppins commented Mar 20, 2019

Splaktar left a comment

jbogarthyde commented Mar 25, 2019 •

edited

mary-poppins commented Mar 25, 2019

mary-poppins commented Mar 25, 2019

Splaktar left a comment

Splaktar Mar 26, 2019

mary-poppins commented Mar 26, 2019

mary-poppins commented Mar 26, 2019

Splaktar Mar 26, 2019

jbogarthyde Mar 26, 2019

Splaktar Mar 26, 2019

jbogarthyde Mar 26, 2019

mary-poppins commented Mar 26, 2019

mary-poppins commented Mar 26, 2019

Splaktar left a comment

mary-poppins commented Mar 27, 2019

mary-poppins commented Mar 27, 2019

angular-automatic-lock-bot bot commented Sep 14, 2019

	The following properties at the top level of the file configure the workspace.
	The following are properties at the top level of the workspace configuration file:

Add schematic details and links to config page #27272

Add schematic details and links to config page #27272

Conversation

jbogarthyde commented Nov 26, 2018

PR Checklist

PR Type

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

Other information

mary-poppins commented Nov 27, 2018

alan-agius4 Nov 27, 2018

Choose a reason for hiding this comment

hansl Dec 14, 2018

Choose a reason for hiding this comment

jbogarthyde Dec 14, 2018 • edited

Choose a reason for hiding this comment

mary-poppins commented Nov 27, 2018

mary-poppins commented Nov 27, 2018

mary-poppins commented Nov 27, 2018

mary-poppins commented Nov 27, 2018

mary-poppins commented Nov 30, 2018

mary-poppins commented Dec 3, 2018

mary-poppins commented Mar 14, 2019

mary-poppins commented Mar 19, 2019

mary-poppins commented Mar 20, 2019

Splaktar left a comment

Choose a reason for hiding this comment

jbogarthyde commented Mar 25, 2019 • edited

mary-poppins commented Mar 25, 2019

mary-poppins commented Mar 25, 2019

Splaktar left a comment

Choose a reason for hiding this comment

Splaktar Mar 26, 2019

Choose a reason for hiding this comment

mary-poppins commented Mar 26, 2019

mary-poppins commented Mar 26, 2019

Splaktar Mar 26, 2019

Choose a reason for hiding this comment

jbogarthyde Mar 26, 2019

Choose a reason for hiding this comment

Splaktar Mar 26, 2019

Choose a reason for hiding this comment

jbogarthyde Mar 26, 2019

Choose a reason for hiding this comment

mary-poppins commented Mar 26, 2019

mary-poppins commented Mar 26, 2019

Splaktar left a comment

Choose a reason for hiding this comment

mary-poppins commented Mar 27, 2019

mary-poppins commented Mar 27, 2019

angular-automatic-lock-bot bot commented Sep 14, 2019

jbogarthyde Dec 14, 2018 •

edited

jbogarthyde commented Mar 25, 2019 •

edited