refactor(ivy): delete the old global-analysis based ivy compiler #27306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhevery
approved these changes
Nov 27, 2018
|
You can preview 4eaf69f at https://pr27306-4eaf69f.ngbuilds.io/. |
alfaproject
reviewed
Nov 28, 2018
| @@ -110,7 +98,6 @@ class AngularCompilerProgram implements Program { | |||
| private _programWithStubs: ts.Program|undefined; | |||
| private _optionsDiagnostics: Diagnostic[] = []; | |||
| // TODO(issue/24571): remove '!'. | |||
This commit deletes the old Ivy compiler (enableIvy: true) which was based on ngc's global analysis of the application and all libraries. This commit also switches the behavior of enableIvy to use 'true' to enable ngtsc.
alxhub
force-pushed
the
ngtsc-remove-global-ivy-compiler
branch
from
4eaf69f
to
0eece0e
Compare
14 tasks
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit deletes the old Ivy compiler (enableIvy: true) which was based
on ngc's global analysis of the application and all libraries. This commit
also switches the behavior of enableIvy to use 'true' to enable ngtsc.