Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(upgrade): add diagnosis to failing ivy tests #27542

Closed
wants to merge 1 commit into from
Closed

test(upgrade): add diagnosis to failing ivy tests #27542

wants to merge 1 commit into from

Conversation

petebacondarwin
Copy link
Member

No description provided.

@petebacondarwin petebacondarwin added area: testing Issues related to Angular testing features, such as TestBed effort1: hours comp: upgrade/dynamic freq1: low target: major This PR is targeted for the next major release risk: low labels Dec 7, 2018
@petebacondarwin petebacondarwin added this to the Ivy milestone Dec 7, 2018
@mary-poppins
Copy link

You can preview f23e0ed at https://pr27542-f23e0ed.ngbuilds.io/.

gkalpak
gkalpak approved these changes Dec 7, 2018
View reviewed changes
packages/upgrade/test/dynamic/upgrade_spec.ts Outdated Show resolved Hide resolved
@gkalpak gkalpak added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Dec 7, 2018
@petebacondarwin petebacondarwin added action: review The PR is still awaiting reviews from at least one requested reviewer and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Dec 7, 2018
@mary-poppins
Copy link

You can preview f82eac9 at https://pr27542-f82eac9.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 45af1bd at https://pr27542-45af1bd.ngbuilds.io/.

@petebacondarwin petebacondarwin added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Dec 7, 2018
@ngbot
Copy link

ngbot bot commented Dec 7, 2018

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure status "buildkite/angular" is failing
    pending 1 pending code review

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@petebacondarwin
Copy link
Member Author

CARETAKER: I believe we are ignoring BuildKite

@mhevery mhevery added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Dec 7, 2018
@alxhub alxhub closed this in 2a35471 Dec 7, 2018
@petebacondarwin petebacondarwin deleted the upgrade-ivy-2 branch December 8, 2018 07:43
ngfelixl pushed a commit to ngfelixl/angular that referenced this pull request Jan 28, 2019
@petebacondarwin @ngfelixl
test(upgrade): add diagnosis to failing ivy tests (angular#27542)
b282cd6 
PR Close angular#27542
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mhevery mhevery mhevery approved these changes

@gkalpak gkalpak gkalpak approved these changes

@kara kara Awaiting requested review from kara

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: testing Issues related to Angular testing features, such as TestBed cla: yes effort1: hours freq1: low merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note risk: low target: major This PR is targeted for the next major release
Projects
None yet
Milestone
Ivy (not in use)
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@petebacondarwin @mary-poppins @mhevery @gkalpak @googlebot