Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: update recommended buildkite VM #27728

Closed
wants to merge 1 commit into from
Closed

ci: update recommended buildkite VM #27728

wants to merge 1 commit into from

Conversation

filipesilva
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: part of #27508

What is the new behavior?

Updated information on how to provision buildkite VM.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@filipesilva filipesilva mentioned this pull request Dec 18, 2018
Closed
alexeagle
alexeagle reviewed Dec 19, 2018
View reviewed changes
.buildkite/provision-windows-buildkite.ps1
@@ -54,6 +54,8 @@ Write-Host "Installing Git for Windows."
Invoke-WebRequest -Uri https://github.com/git-for-windows/git/releases/download/v2.19.1.windows.1/Git-2.19.1-64-bit.exe -OutFile git.exe
.\git.exe /VERYSILENT /NORESTART /NOCANCEL /SP- /CLOSEAPPLICATIONS /RESTARTAPPLICATIONS /COMPONENTS="icons,ext\reg\shellhere,assoc,assoc_sh" /DIR="C:\git"
Add-Path "C:\git\bin"
# Sleep for 15s while git is installed. Trying to remove the git.exe before it finishes install causes an error.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yuck, how do you know that 15s is long enough? can we somehow check whether the thing is done and sleep more if it's not?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, I do not know if 15s is always enough. I checked all the available flags for the git installer executable (https://github.com/git-for-windows/git/wiki/Silent-or-Unattended-Installation) and couldn't really find something that blocks on waiting.

The Bazel folks install it via choco (https://github.com/bazelbuild/continuous-integration/blob/322aa74d4ce07ead7f9560b773712f3c27c8deb9/buildkite/setup-windows.ps1#L82-L86) so I think they avoid this problem.

Which of course begs the question of how chocolatey does it. The files they use can be seen at https://chocolatey.org/packages/git.install/2.20.1. Nothing really obvious catches my attention in their powershell scripts.

I think I need to test this script better overall.

@filipesilva filipesilva added target: major This PR is targeted for the next major release merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels Jan 2, 2019
@ngbot ngbot bot added the action: merge The PR is ready for merge by the caretaker label Jan 8, 2019
@kara kara closed this in 917c09c Jan 8, 2019
devversion pushed a commit to devversion/angular that referenced this pull request Jan 9, 2019
@filipesilva @devversion
ci: update recommended buildkite VM (angular#27728)
6c52e43 
PR Close angular#27728
ngfelixl pushed a commit to ngfelixl/angular that referenced this pull request Jan 28, 2019
@filipesilva @ngfelixl
ci: update recommended buildkite VM (angular#27728)
f57a624 
PR Close angular#27728
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alexeagle alexeagle alexeagle approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@filipesilva @alexeagle @googlebot