Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(platform-browser): add service to get and set favicon #27913

Closed
wants to merge 6 commits into from
Closed

feat(platform-browser): add service to get and set favicon #27913

wants to merge 6 commits into from

Conversation

imaka
Copy link

@imaka imaka commented Jan 3, 2019

feat(platform-browser): add service to get and set favicon

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Angular does not currently provide an easy way to access and modify the favicon programatically.

Issue Number: N/A

What is the new behavior?

The new service gets the existing favicon link tag or sets it (will create or update)

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

feat(platform-browser): add service to get and set favicon
@imaka imaka closed this Jan 4, 2019
@imaka imaka deleted the favicon-service branch January 4, 2019 10:27
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants