Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ivy): validate props and attrs with "on" prefix at runtime #28054

Closed
wants to merge 2 commits into from
Closed

fix(ivy): validate props and attrs with "on" prefix at runtime #28054

wants to merge 2 commits into from

Commits on Jan 12, 2019

  1. fix(ivy): validate props and attrs with "on" prefix at runtime 

    Prior to this change we performed prop and attr name validation at compile time, which failed in case a given prop/attr is an input to a Directive (thus should not be a subject to this check). Since Directive matching in Ivy happens at runtime, the corresponding checks are now moved to runtime as well.
    @AndrewKushnir
    AndrewKushnir committed Jan 12, 2019
    Copy the full SHA
    7f9440b View commit details
    Browse the repository at this point in the history

  2. fixup! fix(ivy): validate props and attrs with "on" prefix at runtime

    @AndrewKushnir
    AndrewKushnir committed Jan 12, 2019
    Copy the full SHA
    8535a52 View commit details
    Browse the repository at this point in the history