fix(ivy): ensure element removal triggers host removal animations #28162
Conversation
|
You can preview 5542c5f at https://pr28162-5542c5f.ngbuilds.io/. |
|
You can preview d678291 at https://pr28162-d678291.ngbuilds.io/. |
|
You can preview 61da545 at https://pr28162-61da545.ngbuilds.io/. |
|
You can preview a500f28 at https://pr28162-a500f28.ngbuilds.io/. |
|
You can preview f8f4abf at https://pr28162-f8f4abf.ngbuilds.io/. |
| // it will help the renderer to decide whether anything special before | ||
| // removal (like calling the leave animation (if defined) on the element | ||
| // before it is removed from the page). | ||
| const isHostElement = (tNode.flags & TNodeFlags.isComponent) > 0; |
There was a problem hiding this comment.
You can use the isComponent util here:
| const isHostElement = (tNode.flags & TNodeFlags.isComponent) > 0; | |
| nativeRemoveChild(renderer, parent !, node, isComponent(tNode)); |
| @Component({ | ||
| selector: 'ani-cmp', | ||
| template: ` | ||
| fixmeIvy('unknown').it( |
There was a problem hiding this comment.
Can you look into why your change doesn't fix this test? If there is a different root cause, we should create a Jira ticket and link it here.
kara
added
action: cleanup
|
You can preview e97daca at https://pr28162-e97daca.ngbuilds.io/. |
|
You can preview 0ed8966 at https://pr28162-0ed8966.ngbuilds.io/. |
Prior to this fix Ivy would not execute any animation triggers that exist as host bindings on an element if it is removed by the parent template.
matsko
removed
the
action: cleanup
|
You can preview 420e869 at https://pr28162-420e869.ngbuilds.io/. |
…gular#28162) Prior to this fix Ivy would not execute any animation triggers that exist as host bindings on an element if it is removed by the parent template. PR Close angular#28162
…gular#28162) Prior to this fix Ivy would not execute any animation triggers that exist as host bindings on an element if it is removed by the parent template. PR Close angular#28162
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Prior to this fix Ivy would not execute any animation triggers
that exist as host bindings on an element if it is removed by
the parent template.