Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(router): initalize browserUrlTree to empty tree #28376

Closed
wants to merge 1 commit into from
Closed

refactor(router): initalize browserUrlTree to empty tree #28376

wants to merge 1 commit into from

Commits on Jan 25, 2019

  1. refactor(router): initalize browserUrlTree to empty tree 

    The value here is unimportant on initialization since it's not looked at until the second navigation. However, sometimes in testing  the `Location` service is mocked out, or the Router constructor manually called. Assuming `Location` exists in the constructor leads to test failures in `google3` therefore we initialize to a value that will not cause errors.
    @jasonaden
    jasonaden committed Jan 25, 2019
    Configuration menu
    Copy the full SHA
    78f2cb4 View commit details
    Browse the repository at this point in the history