Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ivy): remove DOM nodes from their real parent vs saved parent #28455

Closed
wants to merge 2 commits into from
Closed

fix(ivy): remove DOM nodes from their real parent vs saved parent #28455

wants to merge 2 commits into from

Commits on Feb 5, 2019

  1. fix(ivy): remove DOM nodes from their real parent vs saved parent 

    Currently, DOM node removal called `removeChild` on the saved parent
node when destroying a component. However, this will fail if the
component has been manually moved in the DOM. This change makes the
removal always use the node's real `parentNode` and ignore the provided
`parent`.
    @jelbourn
    jelbourn committed Feb 5, 2019
    Copy the full SHA
    79cb1f3 View commit details
    Browse the repository at this point in the history

  2. refactor(ivy): move around logic of getting render parent

    @pkozlowski-opensource @jelbourn
    pkozlowski-opensource authored and jelbourn committed Feb 5, 2019
    Copy the full SHA
    cf528fa View commit details
    Browse the repository at this point in the history