Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(ivy): root cause analysis for e2e tests in common #28506

Closed
wants to merge 1 commit into from
Closed

test(ivy): root cause analysis for e2e tests in common #28506

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
21 changes: 10 additions & 11 deletions packages/examples/common/ngComponentOutlet/ts/e2e_test/ngComponentOutlet_spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
* found in the LICENSE file at https://angular.io/license
*/

import {fixmeIvy} from '@angular/private/testing';
import {fixmeIvy, modifiedInIvy} from '@angular/private/testing';
import {$, ExpectedConditions, browser, by, element} from 'protractor';

import {verifyNoBrowserErrors} from '../../../../test-utils';
Expand All @@ -17,9 +17,7 @@ function waitForElement(selector: string) {
browser.wait(EC.presenceOf($(selector)), 20000);
}

fixmeIvy(
'unknown. Run "yarn bazel run packages/examples/common:devserver --define=compile=aot" ' +
'to debug')
fixmeIvy('FW-1022: JitCompilerFactory creates incorrect compiler instance')
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that the fixme here is around the describe, rather than the failing test, because the component used for the test throws an error which causes all the of the other tests to fail.

.describe('ngComponentOutlet', () => {
const URL = '/ngComponentOutlet';
afterEach(verifyNoBrowserErrors);
Expand All @@ -31,13 +29,14 @@ fixmeIvy(
expect(element.all(by.css('hello-world')).getText()).toEqual(['Hello World!']);
});

it('should render complete', () => {
browser.get(URL);
waitForElement('ng-component-outlet-complete-example');
expect(element.all(by.css('complete-component')).getText()).toEqual([
'Complete: AhojSvet!'
]);
});
modifiedInIvy('Different behavior for projectableNodes in ViewContainerRef.createComponent')
.it('should render complete', () => {
browser.get(URL);
waitForElement('ng-component-outlet-complete-example');
expect(element.all(by.css('complete-component')).getText()).toEqual([
'Complete: AhojSvet!'
]);
});

it('should render other module', () => {
browser.get(URL);
Expand Down
4 changes: 2 additions & 2 deletions packages/examples/common/ngIf/ts/e2e_test/ngIf_spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
* found in the LICENSE file at https://angular.io/license
*/

import {fixmeIvy} from '@angular/private/testing';
import {modifiedInIvy} from '@angular/private/testing';
import {$, ExpectedConditions, browser, by, element} from 'protractor';
import {verifyNoBrowserErrors} from '../../../../test-utils';

Expand Down Expand Up @@ -46,7 +46,7 @@ describe('ngIf', () => {
describe('ng-if-then-else', () => {
let comp = 'ng-if-then-else';

fixmeIvy('unknown. Run "yarn bazel run packages/examples/common:devserver" to debug')
modifiedInIvy('FW-1019: Design new API to replace static queries')
.it('should hide/show content', () => {
browser.get(URL);
waitForElement(comp);
Expand Down