Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(docs-infra): update terser version in lockfile #28512

Closed
wants to merge 1 commit into from

Conversation

filipesilva
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

See angular/angular-cli#13582 (comment).

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@filipesilva filipesilva requested a review from a team as a code owner February 4, 2019 14:18
@mary-poppins
Copy link

You can preview 0eecd2f at https://pr28512-0eecd2f.ngbuilds.io/.

Copy link
Member

@gkalpak gkalpak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this will be necessary after #28510 (but probably doesn't hurt either).

@gkalpak gkalpak changed the title build: update terser version in lockfile build(docs-infra): update terser version in lockfile Feb 4, 2019
@gkalpak
Copy link
Member

gkalpak commented Feb 4, 2019

@filipesilva, can you please change the commit message to build(docs-infra): ...?

@gkalpak gkalpak added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews area: build & ci Related the build and CI infrastructure of the project comp: docs-infra target: patch This PR is targeted for the next patch release labels Feb 4, 2019
@ngbot ngbot bot added this to the needsTriage milestone Feb 4, 2019
@filipesilva
Copy link
Contributor Author

@gkalpak done.

@mary-poppins
Copy link

You can preview 122f9b3 at https://pr28512-122f9b3.ngbuilds.io/.

@kara kara added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Feb 4, 2019
@gkalpak
Copy link
Member

gkalpak commented Feb 4, 2019

For future reference:
Actually, this is not necessary even without #28510 (since the lockfile is ignored in the affected builds), but still doesn't hurt either.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants