fix(ivy): throw on bindings to unknown properties #28537
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kara
added
state: WIP
target: major
kara
changed the title
kara
force-pushed
the
unknown
branch
3 times, most recently
from
b89f9d7
to
a625e1e
Compare
kara
changed the title
kara
force-pushed
the
unknown
branch
2 times, most recently
from
52db716
to
f88848c
Compare
kara
added
action: review
|
Oof, seems like this PR uncovered an unrelated bug with inheriting host bindings inappropriately :( |
trotyl
reviewed
Feb 6, 2019
kara
force-pushed
the
unknown
branch
2 times, most recently
from
7200265
to
9f7d76d
Compare
This commit adds a devMode-only check which will throw if a user attempts to bind a property that does not match a directive input or a known HTML property. Example: ``` <div [unknownProp]="someValue"></div> ``` The above will throw because "unknownProp" is not a known property of HTMLDivElement. This check is similar to the check executed in View Engine during template parsing, but occurs at runtime instead of compile-time. Note: This change uncovered an existing bug with host binding inheritance, so some Material tests had to be turned off. They will be fixed in an upcoming PR.
mhevery
approved these changes
Feb 7, 2019
kara
added
action: presubmit
|
merge-assistance: global approval not working |
kara
added a commit
to kara/angular
that referenced
this pull request
Feb 7, 2019
The behavior tested here was fixed by angular#28537, but I missed updating the test in the original PR. This commit turns on the test to run in Ivy mode, using "onlyInIvy" because the timing of the error message is slightly different and requires CD to run.
kara
added a commit
to kara/angular
that referenced
this pull request
Feb 7, 2019
The behavior tested here was fixed by angular#28537, but I missed updating the test in the original PR. This commit turns on the test to run in Ivy mode, using "onlyInIvy" because the timing of the error message is slightly different and requires CD to run.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a devMode check which will throw if a user
attempts to bind a property that does not match a directive
input or a known HTML property.