Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: convert tree benchmarks to bazel #28568

Closed
wants to merge 4 commits into from
Closed

build: convert tree benchmarks to bazel #28568

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ca3798e
build: unable to run perf bazel e2e tests on windows
devversion Feb 6, 2019
9f48f11
build: serve benchmark tree examples with bazel
devversion Feb 6, 2019
ee5d09b
build: run tree benchmark tests with bazel
devversion Feb 6, 2019
42fc032
build: remove outdated polymer tree benchmark
devversion Feb 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions modules/benchmarks/BUILD.bazel
View file
Open in desktop
@@ -1,5 +1,10 @@
package(default_visibility = ["//visibility:public"])

exports_files([
"tsconfig-build.json",
"start-server.js",
])

filegroup(
name = "favicon",
srcs = [
Expand Down
24 changes: 24 additions & 0 deletions modules/benchmarks/benchmark_test.bzl
View file
Open in desktop
@@ -0,0 +1,24 @@
load("//packages/bazel:index.bzl", "protractor_web_test_suite")

"""
Macro that can be used to define a benchmark test. This differentiates from
a normal Protractor test suite because we specify a custom "perf" configuration
that sets up "@angular/benchpress".
"""

def benchmark_test(name, server, deps, tags = []):
protractor_web_test_suite(
name = name,
configuration = "//:protractor-perf.conf.js",
data = [
"//packages/bazel/src/protractor/utils",
"//packages/benchpress",
],
on_prepare = "//modules/benchmarks:start-server.js",
server = server,
tags = tags,
deps = [
"@ngdeps//protractor",
"@ngdeps//yargs",
] + deps,
)
79 changes: 0 additions & 79 deletions modules/benchmarks/e2e_test/tree_data.ts
View file
Open in desktop

This file was deleted.

93 changes: 0 additions & 93 deletions modules/benchmarks/e2e_test/tree_perf.ts
View file
Open in desktop

This file was deleted.

63 changes: 0 additions & 63 deletions modules/benchmarks/e2e_test/tree_spec.ts
View file
Open in desktop

This file was deleted.

8 changes: 1 addition & 7 deletions modules/benchmarks/src/BUILD.bazel
View file
Open in desktop
Expand Up @@ -4,13 +4,7 @@ load("//tools:defaults.bzl", "ts_library")

ts_library(
name = "util_lib",
srcs = [
"util.ts",
],
deps = [
"//packages:types",
"//packages/core",
],
srcs = ["util.ts"],
)

ts_library(
Expand Down
31 changes: 21 additions & 10 deletions modules/benchmarks/src/tree/BUILD.bazel
View file
Open in desktop
Expand Up @@ -4,25 +4,36 @@ load("//tools:defaults.bzl", "ts_library")

ts_library(
name = "util_lib",
srcs = [
"util.ts",
],
srcs = ["util.ts"],
deps = ["//modules/benchmarks/src:util_lib"],
)

ts_library(
name = "test_utils_lib",
testonly = 1,
srcs = ["tree_perf_test_utils.ts"],
deps = [
"//modules/benchmarks/src:util_lib",
"//packages:types",
"//packages/core",
"//modules/e2e_util",
"@ngdeps//protractor",
],
)

ts_library(
name = "perf_lib",
testonly = 1,
srcs = [
"tree_perf.spec.ts",
srcs = ["tree_perf.spec.ts"],
deps = [
":test_utils_lib",
"@ngdeps//protractor",
],
)

ts_library(
name = "perf_detect_changes_lib",
testonly = 1,
srcs = ["tree_perf_detect_changes.spec.ts"],
deps = [
"//modules/e2e_util",
"//packages:types",
":test_utils_lib",
"@ngdeps//protractor",
],
)
29 changes: 29 additions & 0 deletions modules/benchmarks/src/tree/baseline/BUILD.bazel
View file
Open in desktop
@@ -0,0 +1,29 @@
load("//tools:defaults.bzl", "ts_library")
load("@build_bazel_rules_typescript//:defs.bzl", "ts_devserver")
load("//modules/benchmarks:benchmark_test.bzl", "benchmark_test")

package(default_visibility = ["//modules/benchmarks:__subpackages__"])

ts_library(
name = "baseline",
srcs = glob(["*.ts"]),
tsconfig = "//modules/benchmarks:tsconfig-build.json",
deps = [
"//modules/benchmarks/src:util_lib",
"//modules/benchmarks/src/tree:util_lib",
],
)

ts_devserver(
name = "devserver",
entry_module = "angular/modules/benchmarks/src/tree/baseline/index",
index_html = "index.html",
port = 4200,
deps = [":baseline"],
)

benchmark_test(
name = "perf",
server = ":devserver",
deps = ["//modules/benchmarks/src/tree:perf_lib"],
)
12 changes: 5 additions & 7 deletions modules/benchmarks/src/tree/baseline/index.html
View file
Open in desktop
@@ -1,5 +1,9 @@
<!doctype html>
<html>
<head>
<!-- Prevent the browser from requesting any favicon. -->
<link rel="icon" href="data:,">
</head>
<body>

<h2>Params</h2>
Expand All @@ -21,11 +25,5 @@ <h2>Baseline Tree Benchmark</h2>
<div>
<tree id="root">Loading...</tree>
</div>

<script>
var mainUrl = window.location.search.split(/[?&]main=([^&]+)/)[1]
|| '../../bootstrap_plain.js';
document.write('<script src="' + mainUrl + '">\u003c/script>');
</script>
</body>
</html>
</html>