Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(service-worker): can't cache resource with space in url #28768

Closed
wants to merge 1 commit into from
Closed

fix(service-worker): can't cache resource with space in url #28768

wants to merge 1 commit into from

Conversation

CazzanigaGianluca
Copy link

@CazzanigaGianluca CazzanigaGianluca commented Feb 15, 2019

Replaced '%20' string with space char

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #25443

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@CazzanigaGianluca CazzanigaGianluca requested a review from a team as a code owner February 15, 2019 21:52
@benlesh benlesh added the area: service-worker Issues related to the @angular/service-worker package label Feb 20, 2019
@ngbot ngbot bot added this to the needsTriage milestone Feb 20, 2019
@Splaktar
Copy link
Member

Splaktar commented Mar 2, 2019

Please update your PR title and Commit message to follow these guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit

@CazzanigaGianluca CazzanigaGianluca changed the title fix(#25443): can't cache resource with space in url fix(service-worker): can't cache resource with space in url Mar 2, 2019
Replaced '%20' string with space char

This commit fix #25443
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: service-worker Issues related to the @angular/service-worker package cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants