fix(http): status code; test(http): normalize responseText/response; #2882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PatrickJS
changed the title
PatrickJS
force-pushed
the
status-XHRConnection
branch
from
727b148
to
bc80d66
Compare
tbosch
added
action: review
PatrickJS
force-pushed
the
status-XHRConnection
branch
from
bc80d66
to
cbedf3d
Compare
|
@gdi2290 What is the status of this PR? |
closes angular#2841 - [x] Tests
PatrickJS
force-pushed
the
status-XHRConnection
branch
from
cbedf3d
to
95c1c3c
Compare
|
@tbosch I rebased so it should be good when travis is done |
normalize xhr.responseText and xhr.response - [x] Tests
PatrickJS
force-pushed
the
status-XHRConnection
branch
from
95c1c3c
to
19426a6
Compare
|
@tbosch all green and ready to be merged |
|
@gdi2290 thanks, I'll give a final look. |
mhevery
pushed a commit
that referenced
this pull request
Aug 4, 2015
normalize xhr.responseText and xhr.response - [x] Tests Closes #2882
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(http): status code; test(http): normalize responseText/response;
closes #2841