Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(docs-infra): upgrade cli command docs sources to c91579a2e #28922

Closed

Conversation

gkalpak
Copy link
Member

@gkalpak gkalpak commented Feb 22, 2019

Updating angular#master from cli-builds#master.
Relevant changes in commit range:

Modified

  • help/build.json

Removed

  • help/eject.json

Closes #28772
Closes #28795
Closes #28816
Closes #28859
Closes #28882

Updating [angular#master](https://github.com/angular/angular/tree/master) from [cli-builds#master](https://github.com/angular/cli-builds/tree/master).
Relevant changes in [commit range](angular/cli-builds@1631f7d...c91579a):

**Modified**
- help/build.json

**Removed**
- help/eject.json

Closes angular#28772
Closes angular#28795
Closes angular#28816
Closes angular#28859
Closes angular#28882
@mary-poppins
Copy link

You can preview 0a52460 at https://pr28922-0a52460.ngbuilds.io/.

@gkalpak gkalpak added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Feb 22, 2019
@benlesh benlesh added action: review The PR is still awaiting reviews from at least one requested reviewer and removed action: merge The PR is ready for merge by the caretaker labels Feb 22, 2019
Copy link
Contributor

@kapunahelewong kapunahelewong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brandonroberts brandonroberts added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Feb 22, 2019
@benlesh benlesh closed this in 7c20bf8 Feb 22, 2019
@gkalpak gkalpak deleted the upgrade-cli-src--master--c91579a2e branch February 27, 2019 09:16
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker aio: preview cla: yes effort1: hours feature Issue that requests a new feature risk: low target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants