Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

7.2.x workspaces #28965

Closed
wants to merge 3 commits into from
Closed

7.2.x workspaces #28965

wants to merge 3 commits into from

Conversation

filipesilva
Copy link
Contributor

@filipesilva filipesilva commented Feb 25, 2019 •
edited

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the new behavior?

Port of #28928 and #28935 to 7.2.x

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@filipesilva filipesilva requested a review from a team as a code owner February 25, 2019 17:08
@alexeagle alexeagle added PR target: patch-only action: merge The PR is ready for merge by the caretaker labels Feb 25, 2019
@benlesh benlesh added the area: build & ci Related the build and CI infrastructure of the project label Feb 25, 2019
@ngbot ngbot bot added this to the needsTriage milestone Feb 25, 2019
benlesh pushed a commit that referenced this pull request Feb 25, 2019
@filipesilva @benlesh
ci: share data between jobs using workspaces (#28928) (#28965)
bcbd7ed 
PR Close #28928

PR Close #28965
benlesh pushed a commit that referenced this pull request Feb 25, 2019
@filipesilva @benlesh
ci: rename install job to setup (#28935) (#28965)
a634deb 
Followup to #28928 (review)

PR Close #28935

PR Close #28965
benlesh pushed a commit that referenced this pull request Feb 25, 2019
@filipesilva @benlesh
ci: add bazel_repository_cache to CircleCI workspace (#28935) (#28965)
d374787 
PR Close #28935

PR Close #28965
@benlesh
Copy link
Contributor

benlesh commented Feb 25, 2019

Closed by d374787

@benlesh benlesh closed this Feb 25, 2019
filipesilva added a commit to filipesilva/angular that referenced this pull request Feb 26, 2019
@filipesilva
ci: add workspace prereq job to saucelabs_tests
b432980 
Port of angular#28939, followup to angular#28965.
@filipesilva filipesilva mentioned this pull request Feb 26, 2019
Closed
14 tasks
benlesh pushed a commit that referenced this pull request Feb 26, 2019
@filipesilva @benlesh
ci: add workspace prereq job to saucelabs_tests (#28973)
5b5b989 
Port of #28939, followup to #28965.

PR Close #28973
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alexeagle alexeagle alexeagle approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project cla: yes
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@filipesilva @benlesh @alexeagle @googlebot