feat(ivy): support inline <style> and <link> tags in components #28997
Conversation
|
As part of this PR, could you please enable the |
alxhub
force-pushed
the
ngtsc-inline-resources
branch
from
5b02ae3
to
a891a1d
Compare
Angular supports using <style> and <link> tags inline in component templates, but previously such tags were not implemented within the ngtsc compiler. This commit introduces that support. FW-1069 #resolve
alxhub
force-pushed
the
ngtsc-inline-resources
branch
from
a891a1d
to
8c0f040
Compare
| @@ -319,7 +317,10 @@ function getE2eSpecs(basePath, filter) { | |||
| // Find all e2e specs in a given example folder. | |||
| function getE2eSpecsFor(basePath, specFile, filter) { | |||
| // Only get spec file at the example root. | |||
| // The formatter doesn't understand nested template string expressions (honestly, neither do I). | |||
| // clang-format off | |||
| if (ts.isStringLiteral(templateExpr) || ts.isNoSubstitutionTemplateLiteral(templateExpr)) { | ||
| // the start and end of the `templateExpr` node includes the quotation marks, which we | ||
| // must | ||
| // strip |
| const jsContents = env.getContents('test.js'); | ||
| expect(jsContents).toContain('styles: ["h1[_ngcontent-%COMP%] {font-size: larger}"]'); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
Should there be similar tests for templateUrl components?
There was a problem hiding this comment.
We already have tests that verify templateUrl works correctly. The logic is such that the origin of the template doesn't matter by the time we extract <style> and <link>.
alxhub
added
action: merge
|
Caretaker: I am the approver for fw-compiler, so this is good to go. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Angular supports using <style> and tags inline in component
templates, but previously such tags were not implemented within the ngtsc
compiler. This commit introduces that support.