Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for TypeScript 3.3 (and drop older versions) #29004

Closed
wants to merge 3 commits into from

Conversation

Projects
None yet
7 participants
@filipesilva
Copy link
Member

commented Feb 27, 2019

Followup to #28497


https://blogs.msdn.microsoft.com/typescript/2019/01/31/announcing-typescript-3-3/

BREAKING CHANGE: TypeScript 3.1 and 3.2 are no longer supported.

Please update your TypeScript version to 3.3

@filipesilva filipesilva requested review from angular/docs-infra as code owners Feb 27, 2019

@googlebot

This comment has been minimized.

Copy link

commented Feb 27, 2019

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no label Feb 27, 2019

@filipesilva filipesilva force-pushed the filipesilva:28497-followup branch from 648ff39 to 5c12187 Feb 27, 2019

@mary-poppins

This comment has been minimized.

Copy link

commented Feb 27, 2019

@mary-poppins

This comment has been minimized.

Copy link

commented Feb 27, 2019

@filipesilva filipesilva force-pushed the filipesilva:28497-followup branch from 5c12187 to cb0b608 Feb 27, 2019

@mary-poppins

This comment has been minimized.

Copy link

commented Feb 27, 2019

@filipesilva filipesilva force-pushed the filipesilva:28497-followup branch from cb0b608 to 4716214 Feb 27, 2019

@mary-poppins

This comment has been minimized.

Copy link

commented Feb 27, 2019

@googlebot

This comment has been minimized.

Copy link

commented Mar 1, 2019

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@alexeagle

This comment has been minimized.

Copy link
Contributor

commented Mar 1, 2019

@alexeagle

This comment has been minimized.

Copy link
Contributor

commented Mar 1, 2019

fails in g3, I assume it's blocked on updating to TS 3.3.3333 in g3 as well

third_party/javascript/angular2/rc/packages/compiler-cli/src/ngtsc/program.ts:126:7 - error TS2322: Type 'GeneratedShimsHostWrapper' is not assignable to type 'CompilerHost'.
  Property 'getDirectories' is optional in type 'GeneratedShimsHostWrapper' but required in type 'CompilerHost'.

126       this.host = new GeneratedShimsHostWrapper(host, generators);
          ~~~~~~~~~

IgorMinar and others added some commits Feb 2, 2019

@filipesilva filipesilva force-pushed the filipesilva:28497-followup branch from 4716214 to 3b64394 Mar 12, 2019

@googlebot

This comment has been minimized.

Copy link

commented Mar 12, 2019

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot removed the cla: yes label Mar 12, 2019

@googlebot googlebot added the cla: no label Mar 12, 2019

@mary-poppins

This comment has been minimized.

Copy link

commented Mar 12, 2019

@alexeagle alexeagle added cla: yes and removed cla: no labels Mar 12, 2019

@googlebot

This comment has been minimized.

Copy link

commented Mar 12, 2019

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@IgorMinar

This comment has been minimized.

Copy link
Member

commented Mar 13, 2019

Thank you for taking care of this!

@kara kara closed this in 75748d6 Mar 13, 2019

@filipesilva filipesilva referenced this pull request Mar 18, 2019

Closed

build: update to TypeScript 3.4 #29372

4 of 14 tasks complete

@filipesilva filipesilva deleted the filipesilva:28497-followup branch Mar 20, 2019

wKoza added a commit to wKoza/angular that referenced this pull request Apr 17, 2019

feat: add support for TypeScript 3.3 (and drop older versions) (angul…
…ar#29004)

https://blogs.msdn.microsoft.com/typescript/2019/01/31/announcing-typescript-3-3/

BREAKING CHANGE: TypeScript 3.1 and 3.2 are no longer supported.

Please update your TypeScript version to 3.3

PR Close angular#29004
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.