Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for TypeScript 3.3 (and drop older versions) #29004

Closed
wants to merge 3 commits into from

Conversation

filipesilva
Copy link
Contributor

Followup to #28497


https://blogs.msdn.microsoft.com/typescript/2019/01/31/announcing-typescript-3-3/

BREAKING CHANGE: TypeScript 3.1 and 3.2 are no longer supported.

Please update your TypeScript version to 3.3

@filipesilva filipesilva requested review from a team as code owners February 27, 2019 10:56
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@mary-poppins
Copy link

You can preview 648ff39 at https://pr29004-648ff39.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 5c12187 at https://pr29004-5c12187.ngbuilds.io/.

@mary-poppins
Copy link

You can preview cb0b608 at https://pr29004-cb0b608.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 4716214 at https://pr29004-4716214.ngbuilds.io/.

@benlesh benlesh added the area: build & ci Related the build and CI infrastructure of the project label Feb 27, 2019
@ngbot ngbot bot added this to the needsTriage milestone Feb 27, 2019
@alexeagle alexeagle added cla: yes and removed cla: no labels Mar 1, 2019
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@alexeagle alexeagle added the target: major This PR is targeted for the next major release label Mar 1, 2019
@alexeagle
Copy link
Contributor

presubmit

@alexeagle
Copy link
Contributor

fails in g3, I assume it's blocked on updating to TS 3.3.3333 in g3 as well

third_party/javascript/angular2/rc/packages/compiler-cli/src/ngtsc/program.ts:126:7 - error TS2322: Type 'GeneratedShimsHostWrapper' is not assignable to type 'CompilerHost'.
  Property 'getDirectories' is optional in type 'GeneratedShimsHostWrapper' but required in type 'CompilerHost'.

126       this.host = new GeneratedShimsHostWrapper(host, generators);
          ~~~~~~~~~

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@mary-poppins
Copy link

You can preview 3b64394 at https://pr29004-3b64394.ngbuilds.io/.

@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@alexeagle alexeagle added the action: merge The PR is ready for merge by the caretaker label Mar 12, 2019
@kara kara added the action: review The PR is still awaiting reviews from at least one requested reviewer label Mar 12, 2019
@IgorMinar
Copy link
Contributor

Thank you for taking care of this!

@IgorMinar IgorMinar removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Mar 13, 2019
@kara kara closed this in 75748d6 Mar 13, 2019
@filipesilva filipesilva mentioned this pull request Mar 18, 2019
14 tasks
@filipesilva filipesilva deleted the 28497-followup branch March 20, 2019 08:31
wKoza pushed a commit to wKoza/angular that referenced this pull request Apr 17, 2019
…ar#29004)

https://blogs.msdn.microsoft.com/typescript/2019/01/31/announcing-typescript-3-3/

BREAKING CHANGE: TypeScript 3.1 and 3.2 are no longer supported.

Please update your TypeScript version to 3.3

PR Close angular#29004
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants