New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for TypeScript 3.3 (and drop older versions) #29004
Conversation
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the ℹ️ Googlers: Go here for more info. |
648ff39
to
5c12187
Compare
You can preview 648ff39 at https://pr29004-648ff39.ngbuilds.io/. |
You can preview 5c12187 at https://pr29004-5c12187.ngbuilds.io/. |
5c12187
to
cb0b608
Compare
You can preview cb0b608 at https://pr29004-cb0b608.ngbuilds.io/. |
cb0b608
to
4716214
Compare
You can preview 4716214 at https://pr29004-4716214.ngbuilds.io/. |
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) ℹ️ Googlers: Go here for more info. |
fails in g3, I assume it's blocked on updating to TS 3.3.3333 in g3 as well
|
https://blogs.msdn.microsoft.com/typescript/2019/01/31/announcing-typescript-3-3/ BREAKING CHANGE: TypeScript 3.1 and 3.2 are no longer supported. Please update your TypeScript version to 3.3
4716214
to
3b64394
Compare
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the ℹ️ Googlers: Go here for more info. |
You can preview 3b64394 at https://pr29004-3b64394.ngbuilds.io/. |
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) ℹ️ Googlers: Go here for more info. |
Thank you for taking care of this! |
…ar#29004) https://blogs.msdn.microsoft.com/typescript/2019/01/31/announcing-typescript-3-3/ BREAKING CHANGE: TypeScript 3.1 and 3.2 are no longer supported. Please update your TypeScript version to 3.3 PR Close angular#29004
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Followup to #28497
https://blogs.msdn.microsoft.com/typescript/2019/01/31/announcing-typescript-3-3/
BREAKING CHANGE: TypeScript 3.1 and 3.2 are no longer supported.
Please update your TypeScript version to 3.3