Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(router): fixed typo #29082

wants to merge 1 commit into from
Changes from all commits
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.


Just for now

@@ -7,7 +7,7 @@

import {Compiler, InjectionToken, Injector, NgModuleFactory, NgModuleFactoryLoader} from '@angular/core';
// TODO(i): switch to fromPromise once it's expored in rxjs
// TODO(i): switch to fromPromise once it's exported in rxjs
This conversation was marked as resolved by Maxim-Mazurok

This comment has been minimized.

Copy link

alfaproject Mar 3, 2019


I don't think this comment is relevant? from supports promises out of the box.

This comment has been minimized.

Copy link

JoostK Mar 3, 2019


@alfaproject Using fromPromise would allow for better tree-shaking, as from unnecessarily pulls in the logic to handle all kinds of input.

This comment has been minimized.

Copy link

trotyl Mar 3, 2019


Agree with @alfaproject, the attempt is ReactiveX/rxjs#3375 but got rejected at ReactiveX/rxjs#3391. It can be considered settled per ReactiveX/rxjs#3374 (comment), so the comment can just be removed.

This comment has been minimized.

Copy link

Maxim-Mazurok Mar 3, 2019

Author Contributor

Yep, actually, @jasonaden asked to remove this comment in code review: #22573/files#r174976783 but it wasn't removed. So, I will close this PR and open a new one. Thanks!

import {Observable, from, of } from 'rxjs';
import {map, mergeMap} from 'rxjs/operators';
import {LoadChildren, LoadedRouterConfig, Route, standardizeConfig} from './config';
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.