Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FW-1141 (requiredParents insertion mechanism) #29219

Closed
wants to merge 2 commits into from
Closed

FW-1141 (requiredParents insertion mechanism) #29219

wants to merge 2 commits into from

Conversation

pkozlowski-opensource
Copy link
Member

@pkozlowski-opensource pkozlowski-opensource commented Mar 11, 2019 •
edited

This PR removes the requiredParents insertion mechanism.

@kara
Copy link
Contributor

kara commented Mar 11, 2019 •
edited

original presubmit

global presubmit

@ngbot ngbot bot added this to the needsTriage milestone Mar 11, 2019
@pkozlowski-opensource pkozlowski-opensource added action: review The PR is still awaiting reviews from at least one requested reviewer target: major This PR is targeted for the next major release PR action: time-zone labels Mar 11, 2019
@pkozlowski-opensource pkozlowski-opensource marked this pull request as ready for review March 11, 2019 16:21
@pkozlowski-opensource pkozlowski-opensource changed the title Fw 1141 reproduce test FW-1141 (requiredParents insertion mechanism) Mar 12, 2019
kara
kara approved these changes Mar 13, 2019
View reviewed changes
Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kara kara added action: presubmit The PR is in need of a google3 presubmit action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Mar 13, 2019
@ngbot
Copy link

ngbot bot commented Mar 13, 2019

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure conflicts with base branch "master"
    pending status "google3" is pending

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@kara
Copy link
Contributor

kara commented Mar 13, 2019 •
edited

@pkozlowski-opensource FYI i'm going to run a "global" presubmit tonight to make sure screenshot tests are also healthy (normally we just run against our a selection of projects). If it passes, I'll merge it first thing in the morning.

@kara kara added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note action: presubmit The PR is in need of a google3 presubmit labels Mar 13, 2019
@kara
Copy link
Contributor

kara commented Mar 13, 2019

Note: presubmit passes with a patch CL. Need to rebase this and then we should be able to get it in.

@pkozlowski-opensource @kara
fix(core): don't wrap <tr> and <col> elements into a required parent
4f472d6 
BREAKING CHANGE:

Certain elements (like `<tr>` or `<col>`) require parent elements to be of a certain type by the HTML specification
(ex. <tr> can only be inside <tbody> / <thead>). Before this change Angular template parser was auto-correcting
"invalid" HTML using the following rules:
- `<tr>` would be wrapped in `<tbody>` if not inside `<tbody>`, `<tfoot>` or `<thead>`;
- `<col>` would be wrapped in `<colgroup>` if not inside `<colgroup>`.

This meachanism of automatic wrapping / auto-correcting was problematic for several reasons:
- it is non-obvious and arbitrary (ex. there are more HTML elements that has rules for parent type);
- it is incorrect for cases where `<tr>` / `<col>` are at the root of a component's content, ex.:

```html
<projecting-tr-inside-tbody>
  <tr>...</tr>
</projecting-tr-inside-tbody>
```

In the above example the `<projecting-tr-inside-tbody>` component culd be "surprised" to see additional
`<tbody>` elements inserted by Angular HTML parser.
@kara kara removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Mar 13, 2019
@kara kara force-pushed the fw_1141_reproduce_test branch 2 times, most recently from d463d10 to b235cc8 Compare March 13, 2019 23:36
@kara kara added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Mar 13, 2019
@kara
Copy link
Contributor

kara commented Mar 14, 2019

merge-assistance: global approval

@matsko matsko closed this in f2dc32e Mar 14, 2019
matsko pushed a commit that referenced this pull request Mar 14, 2019
@pkozlowski-opensource @matsko
test(ivy): enable passing Material tests (#29219)
1f0eadf 
PR Close #29219
wKoza pushed a commit to wKoza/angular that referenced this pull request Apr 17, 2019
@pkozlowski-opensource @wKoza
fix(core): don't wrap <tr> and <col> elements into a required par…
9235c6a 
…ent (angular#29219)

BREAKING CHANGE:

Certain elements (like `<tr>` or `<col>`) require parent elements to be of a certain type by the HTML specification
(ex. <tr> can only be inside <tbody> / <thead>). Before this change Angular template parser was auto-correcting
"invalid" HTML using the following rules:
- `<tr>` would be wrapped in `<tbody>` if not inside `<tbody>`, `<tfoot>` or `<thead>`;
- `<col>` would be wrapped in `<colgroup>` if not inside `<colgroup>`.

This meachanism of automatic wrapping / auto-correcting was problematic for several reasons:
- it is non-obvious and arbitrary (ex. there are more HTML elements that has rules for parent type);
- it is incorrect for cases where `<tr>` / `<col>` are at the root of a component's content, ex.:

```html
<projecting-tr-inside-tbody>
  <tr>...</tr>
</projecting-tr-inside-tbody>
```

In the above example the `<projecting-tr-inside-tbody>` component culd be "surprised" to see additional
`<tbody>` elements inserted by Angular HTML parser.

PR Close angular#29219
wKoza pushed a commit to wKoza/angular that referenced this pull request Apr 17, 2019
@pkozlowski-opensource @wKoza
test(ivy): enable passing Material tests (angular#29219)
bead0f7 
PR Close angular#29219
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kara kara kara approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: major This PR is targeted for the next major release
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pkozlowski-opensource @kara @googlebot