Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "build: add a nice Angular-themed color for the vscode status … #29419

Closed
wants to merge 1 commit into from
Closed

Revert "build: add a nice Angular-themed color for the vscode status … #29419

wants to merge 1 commit into from

Conversation

alexeagle
Copy link
Contributor

…bar (#29407)"

This reverts commit efcd6af.
Engineers on the team thought that the red color means something is
broken.
See slack discussion in #general

@alexeagle
Revert "build: add a nice Angular-themed color for the vscode status …
e8a571f 
…bar (angular#29407)"

This reverts commit efcd6af.
Engineers on the team thought that the red color means something is
broken.
See slack discussion in #general
@alexeagle alexeagle requested a review from matsko March 20, 2019 15:43
@alexeagle alexeagle requested a review from a team as a code owner March 20, 2019 15:43
@gkalpak gkalpak added area: build & ci Related the build and CI infrastructure of the project target: patch This PR is targeted for the next patch release labels Mar 20, 2019
@ngbot ngbot bot added this to the needsTriage milestone Mar 20, 2019
@gkalpak gkalpak added the action: merge The PR is ready for merge by the caretaker label Mar 20, 2019
matsko pushed a commit that referenced this pull request Mar 20, 2019
@alexeagle @matsko
Revert "build: add a nice Angular-themed color for the vscode status …
32c6d53 
…bar (#29407)" (#29419)

This reverts commit efcd6af.
Engineers on the team thought that the red color means something is
broken.
See slack discussion in #general

PR Close #29419
@matsko matsko closed this in 3121409 Mar 20, 2019
wKoza pushed a commit to wKoza/angular that referenced this pull request Apr 17, 2019
@alexeagle @wKoza
Revert "build: add a nice Angular-themed color for the vscode status …
7b905f8 
…bar (angular#29407)" (angular#29419)

This reverts commit efcd6af.
Engineers on the team thought that the red color means something is
broken.
See slack discussion in #general

PR Close angular#29419
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@filipesilva filipesilva filipesilva approved these changes

@matsko matsko Awaiting requested review from matsko

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@alexeagle @filipesilva @googlebot @gkalpak