Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(bazel): revert back to yarn 1.12.1 under Bazel to fix Windows file-in-use issues #29431

Closed
wants to merge 2 commits into from
Closed

build(bazel): revert back to yarn 1.12.1 under Bazel to fix Windows file-in-use issues #29431

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
adf009c
build(bazel): revert back to yarn 1.12.1 under Bazel to fix Windows f…
gregmagolan Mar 20, 2019
55ddab5
build(bazel): add comment about advancing the version of yarn used un…
gregmagolan Mar 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 9 additions & 1 deletion WORKSPACE
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,15 @@ node_repositories(
node_version = "10.9.0",
package_json = ["//:package.json"],
preserve_symlinks = True,
yarn_version = "1.13.0",
# yarn 1.13.0 under Bazel has a regression on Windows that causes build errors on rebuilds:
# ```
# ERROR: Source forest creation failed: C:/.../fyuc5c3n/execroot/angular/external (Directory not empty)
# ```
# See https://github.com/angular/angular/pull/29431 for more information.
# It possible that versions of yarn past 1.13.0 do not have this issue, however, before
# advancing this version we need to test manually on Windows that the above error does not
# happen as the issue is not caught by CI.
yarn_version = "1.12.1",
gregmagolan marked this conversation as resolved.
Show resolved Hide resolved
)

yarn_install(
Expand Down
2 changes: 1 addition & 1 deletion integration/bazel/WORKSPACE
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ Try running `yarn bazel` instead.
# Setup the Node.js toolchain
node_repositories(
node_version = "10.9.0",
yarn_version = "1.13.0",
yarn_version = "1.12.1",
)

# Install our npm dependencies into @npm
Expand Down