Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bazel): allow ng_module users to set createExternalSymbolFactoryR… #29449

Closed
wants to merge 2 commits into from
Closed

fix(bazel): allow ng_module users to set createExternalSymbolFactoryR… #29449

wants to merge 2 commits into from

Conversation

alexeagle
Copy link
Contributor

…eexports

@alexeagle alexeagle requested a review from a team as a code owner March 21, 2019 20:57
@matsko matsko added the area: bazel Issues related to the published `@angular/bazel` build rules label Mar 21, 2019
@ngbot ngbot bot added this to the needsTriage milestone Mar 21, 2019
gregmagolan
gregmagolan approved these changes Mar 22, 2019
View reviewed changes
Copy link
Contributor

@gregmagolan gregmagolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@gregmagolan
Copy link
Contributor

When we get this working downstream in angular-bazel-example we should update integration/bazel to exercise this

@alexeagle
Copy link
Contributor Author

Keen is planning to include it in his PR that adds router to the integration/bazel example

@kyliau kyliau mentioned this pull request Mar 22, 2019
Closed
14 tasks
@alexeagle alexeagle closed this Mar 27, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gregmagolan gregmagolan gregmagolan approved these changes

Assignees
No one assigned
Labels
area: bazel Issues related to the published `@angular/bazel` build rules cla: yes
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@alexeagle @gregmagolan @matsko @googlebot