Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(forms): add comment of the 'value' property #29898

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@Ly-lns
Copy link

Ly-lns commented Apr 15, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: 15982
#15982

According to the above issue,we can know that for an enabled FormGroup,the 'value' property only contain the enabled values of its children.Howerve,for a disabled FormGroup,the 'value' property contain all the values of its children.This should be written in the comment.

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@Ly-lns Ly-lns requested a review from angular/fw-forms as a code owner Apr 15, 2019

@googlebot

This comment has been minimized.

Copy link

googlebot commented Apr 15, 2019

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no label Apr 15, 2019

@brandonroberts

This comment has been minimized.

Copy link
Contributor

brandonroberts commented Apr 15, 2019

@Ly-lns the CLA requirement must be resolved before this PR can move forward.

@googlebot

This comment has been minimized.

Copy link

googlebot commented Apr 16, 2019

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Apr 16, 2019

@Ly-lns

This comment has been minimized.

Copy link
Author

Ly-lns commented Apr 16, 2019

@brandonroberts thanks.The CLA is signed now!

@Ly-lns Ly-lns force-pushed the Ly-lns:lynette/doc branch from b225d89 to 39aaa3c Apr 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.