Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(forms): add comment of the 'value' property #29898

Closed
wants to merge 1 commit into from

Conversation

lynette-li
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: 15982
#15982

According to the above issue,we can know that for an enabled FormGroup,the 'value' property only contain the enabled values of its children.Howerve,for a disabled FormGroup,the 'value' property contain all the values of its children.This should be written in the comment.

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@lynette-li lynette-li requested a review from a team as a code owner April 15, 2019 07:32
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@brandonroberts
Copy link
Contributor

@Ly-lns the CLA requirement must be resolved before this PR can move forward.

@brandonroberts brandonroberts self-assigned this Apr 15, 2019
@brandonroberts brandonroberts added comp: docs effort1: hours target: patch This PR is targeted for the next patch release risk: low state: community Someone from the Angular community is working on this issue or submitted this PR refactoring Issue that involves refactoring or code-cleanup labels Apr 15, 2019
@ngbot ngbot bot added this to the Backlog milestone Apr 15, 2019
@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@lynette-li
Copy link
Contributor Author

@brandonroberts thanks.The CLA is signed now!

@brandonroberts brandonroberts added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label May 9, 2019
@ngbot ngbot bot added the action: merge The PR is ready for merge by the caretaker label May 9, 2019
@brandonroberts
Copy link
Contributor

Caretaker note: This is a docs only change and should not impact g3. Please run presubmit.

alxhub pushed a commit that referenced this pull request May 9, 2019
@alxhub alxhub closed this in d2c83ea May 9, 2019
BioPhoton pushed a commit to BioPhoton/angular that referenced this pull request May 21, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes effort1: hours merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note refactoring Issue that involves refactoring or code-cleanup risk: low state: community Someone from the Angular community is working on this issue or submitted this PR target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants