Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(docs-infra): temporarily lower the min required PWA score for localhost tests #29911

Closed

Conversation

Projects
None yet
4 participants
@gkalpak
Copy link
Member

gkalpak commented Apr 15, 2019

The PWA score tests have been occasionally failing on CI recently (possibly due to CI VM/network issues).

This commit temporarily disables them, until we investigate the root-cause and/or put a work-around in place.

The PWA score tests are still run against the deployed versions (which don't suffer as much) or PRs with public previews (as part of the test_aio_preview job) and on upstream builds (as part of the deploy_aio job).

Related to #29910.

ci(docs-infra): temporarily lower the min required PWA score for loca…
…lhost tests

The PWA score tests have been occasionally failing on CI recently
(possibly due to CI VM/network issues).

This commit temporarily disables them, until we investigate the
root-cause and/or put a work-around in place.

The PWA score tests are still run against the deployed versions (which
don't suffer as much) or PRs with public previews (as part of the
`test_aio_preview` job) and on upstream builds (as part of the
`deploy_aio` job).

Related to #29910.

[1]: https://github.com/angular/angular/blob/3a836c362/.circleci/config.yml#L390

@gkalpak gkalpak requested a review from angular/fw-dev-infra as a code owner Apr 15, 2019

@googlebot googlebot added the cla: yes label Apr 15, 2019

@ngbot ngbot bot added this to the needsTriage milestone Apr 15, 2019

@alxhub

alxhub approved these changes Apr 15, 2019

alxhub added a commit that referenced this pull request Apr 15, 2019

ci(docs-infra): temporarily lower the min required PWA score for loca…
…lhost tests (#29911)

The PWA score tests have been occasionally failing on CI recently
(possibly due to CI VM/network issues).

This commit temporarily disables them, until we investigate the
root-cause and/or put a work-around in place.

The PWA score tests are still run against the deployed versions (which
don't suffer as much) or PRs with public previews (as part of the
`test_aio_preview` job) and on upstream builds (as part of the
`deploy_aio` job).

Related to #29910.

[1]: https://github.com/angular/angular/blob/3a836c362/.circleci/config.yml#L390

PR Close #29911

@alxhub alxhub closed this in 8027b3e Apr 15, 2019

@gkalpak gkalpak deleted the gkalpak:ci-aio-disable-pwa-on-localhost branch Apr 15, 2019

wKoza added a commit to wKoza/angular that referenced this pull request Apr 17, 2019

ci(docs-infra): temporarily lower the min required PWA score for loca…
…lhost tests (angular#29911)

The PWA score tests have been occasionally failing on CI recently
(possibly due to CI VM/network issues).

This commit temporarily disables them, until we investigate the
root-cause and/or put a work-around in place.

The PWA score tests are still run against the deployed versions (which
don't suffer as much) or PRs with public previews (as part of the
`test_aio_preview` job) and on upstream builds (as part of the
`deploy_aio` job).

Related to angular#29910.

[1]: https://github.com/angular/angular/blob/3a836c362/.circleci/config.yml#L390

PR Close angular#29911
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.