Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(compiler): Fix compiler crash due to isSkipSelf of null #30075

Closed
wants to merge 1 commit into from
Closed

fix(compiler): Fix compiler crash due to isSkipSelf of null #30075

wants to merge 1 commit into from

Conversation

kyliau
Copy link
Contributor

@kyliau kyliau commented Apr 24, 2019 •
edited

PR Closes #20523
PR Closes #27125

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@kyliau kyliau added area: core Issues related to the framework runtime target: major This PR is targeted for the next major release labels Apr 24, 2019
@kyliau kyliau requested a review from a team as a code owner April 24, 2019 00:04
@ngbot ngbot bot added this to the needsTriage milestone Apr 24, 2019
@kyliau kyliau requested a review from alexeagle April 24, 2019 00:05
@kyliau kyliau force-pushed the is-skip-self branch 2 times, most recently from dac873d to 7a83fe5 Compare April 24, 2019 00:26
alexeagle
alexeagle approved these changes Apr 24, 2019
View reviewed changes
Copy link
Contributor

@alexeagle alexeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no test? :(

@alxhub
Copy link
Member

alxhub commented Apr 24, 2019

+1, would like to see a test before merging.

@alexeagle alexeagle added hotlist: release-blocker action: merge The PR is ready for merge by the caretaker labels Apr 24, 2019
@AndrewKushnir AndrewKushnir added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: merge The PR is ready for merge by the caretaker labels Apr 24, 2019
@IgorMinar IgorMinar modified the milestones: needsTriage, version 8 Apr 24, 2019
@kyliau kyliau added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Apr 24, 2019
@kyliau kyliau deleted the is-skip-self branch April 25, 2019 05:22
This was referenced Apr 25, 2019
Closed
Closed
BioPhoton pushed a commit to BioPhoton/angular that referenced this pull request May 21, 2019
@kyliau @BioPhoton
fix(compiler): Fix compiler crash due to isSkipSelf of null (angular#…
4aba544 
…30075)

PR Closes angular#27125

PR Close angular#30075
DavidANeil pushed a commit to lucidsoftware/angular that referenced this pull request May 31, 2019
@kyliau @DavidANeil
fix(compiler): Fix compiler crash due to isSkipSelf of null (angular#…
9fde24d 
…30075)

PR Closes angular#27125

PR Close angular#30075
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alexeagle alexeagle alexeagle approved these changes

@alxhub alxhub alxhub approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Milestone
version 8
6 participants
@kyliau @alxhub @alexeagle @IgorMinar @googlebot @AndrewKushnir