Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler-cli): log ngcc skipping messages as debug instead of info #30232

Closed
wants to merge 1 commit into from

Conversation

@filipesilva
Copy link
Member

commented May 2, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

ngcc messages related to skipping are logged to info, which makes it hard to filter them out.

What is the new behavior?

ngcc messages related to skipping are logged to debug instead of info.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Related to angular/angular-cli#14194, angular/angular-cli#14320

@filipesilva filipesilva requested a review from petebacondarwin May 2, 2019

@filipesilva filipesilva requested a review from angular/fw-ngcc as a code owner May 2, 2019

@googlebot googlebot added the cla: yes label May 2, 2019

@mary-poppins

This comment has been minimized.

Copy link

commented May 2, 2019

@filipesilva filipesilva force-pushed the filipesilva:ngcc-debug-msgs branch from dbee62e to 820db13 May 2, 2019

@filipesilva filipesilva requested a review from angular/fw-integration as a code owner May 2, 2019

@mary-poppins

This comment has been minimized.

Copy link

commented May 2, 2019

@petebacondarwin

This comment has been minimized.

Copy link
Member

commented May 2, 2019

Added master and patch branches because this is important enough for CLI that it should go in 8.0.0

@kara

This comment has been minimized.

Copy link
Contributor

commented May 6, 2019

@filipesilva This doesn't apply cleanly to the patch branch. Can you create a separate PR for the patch branch?

@filipesilva

This comment has been minimized.

Copy link
Member Author

commented May 6, 2019

@kara it's now up at #30289

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.