Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(ivy): move host binding tests to acceptance #30308

Closed
wants to merge 1 commit into from
Closed

test(ivy): move host binding tests to acceptance #30308

wants to merge 1 commit into from

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented May 7, 2019

Switches over all host binding tests to use TestBed and to be under acceptance.

@crisbeto crisbeto force-pushed the host-binding-acceptance-tests branch from 8963213 to 282fb4f Compare May 7, 2019 20:14
@kara kara added the comp: ivy label May 7, 2019
@ngbot ngbot bot added this to the needsTriage milestone May 7, 2019
@crisbeto crisbeto force-pushed the host-binding-acceptance-tests branch 2 times, most recently from 70f4bd9 to a387904 Compare May 8, 2019 02:04
@crisbeto crisbeto added the action: review The PR is still awaiting reviews from at least one requested reviewer label May 8, 2019
@crisbeto crisbeto marked this pull request as ready for review May 8, 2019 02:20
@crisbeto crisbeto requested a review from a team as a code owner May 8, 2019 02:20
kara
kara approved these changes May 8, 2019
View reviewed changes
Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kara kara added target: patch This PR is targeted for the next patch release and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels May 8, 2019
@kara
Copy link
Contributor

kara commented May 8, 2019

@crisbeto Can you change the commit name to test(ivy)?

@kara kara added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews action: merge The PR is ready for merge by the caretaker action: presubmit The PR is in need of a google3 presubmit and removed action: presubmit The PR is in need of a google3 presubmit labels May 8, 2019
@crisbeto crisbeto changed the title refactor(ivy): move host binding tests to acceptance test(ivy): move host binding tests to acceptance May 8, 2019
@crisbeto
test(ivy): move host binding tests to acceptance
cd64b22 
Switches over all host binding tests to use `TestBed` and to be under `acceptance`.
@crisbeto crisbeto removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label May 8, 2019
@crisbeto crisbeto force-pushed the host-binding-acceptance-tests branch from a387904 to cd64b22 Compare May 8, 2019 11:35
@crisbeto crisbeto removed their assignment May 8, 2019
@kara kara added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label May 8, 2019
@kara
Copy link
Contributor

kara commented May 8, 2019

merge-assistance: this is all green but isn't reflecting in the UI

@alxhub alxhub closed this in d9b9ed5 May 8, 2019
alxhub pushed a commit that referenced this pull request May 8, 2019
@crisbeto @alxhub
test(ivy): move host binding tests to acceptance (#30308)
bcc72b0 
Switches over all host binding tests to use `TestBed` and to be under `acceptance`.

PR Close #30308
BioPhoton pushed a commit to BioPhoton/angular that referenced this pull request May 21, 2019
@crisbeto @BioPhoton
test(ivy): move host binding tests to acceptance (angular#30308)
d0d90bc 
Switches over all host binding tests to use `TestBed` and to be under `acceptance`.

PR Close angular#30308
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kara kara kara approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@crisbeto @kara @googlebot