-
Notifications
You must be signed in to change notification settings - Fork 24.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(ivy): rewrite flatten function to be more memory efficient #30468
Closed
Closed
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
16b1e7d
refactor(ivy): rewrite flatten function to be more memory efficient
mhevery 910e47e
fixup! refactor(ivy): rewrite flatten function to be more memory effi…
mhevery 83c7d59
fixup! refactor(ivy): rewrite flatten function to be more memory effi…
mhevery 9f8c4db
fixup! refactor(ivy): rewrite flatten function to be more memory effi…
mhevery File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -30,20 +30,16 @@ function getSymbolIterator() { | |
|
||
if ("undefined" === typeof ngI18nClosureMode) _global["ngI18nClosureMode"] = "undefined" !== typeof goog && "function" === typeof goog.getMsg; | ||
|
||
function flatten(list, mapFn) { | ||
const result = []; | ||
let i = 0; | ||
while (i < list.length) { | ||
const item = list[i]; | ||
if (Array.isArray(item)) if (item.length > 0) { | ||
list = item.concat(list.slice(i + 1)); | ||
i = 0; | ||
} else i++; else { | ||
result.push(mapFn ? mapFn(item) : item); | ||
i++; | ||
} | ||
} | ||
return result; | ||
function flatten(list, dst) { | ||
if (void 0 === dst) dst = list; | ||
for (let i = 0; i < list.length; i++) { | ||
let item = list[i]; | ||
if (Array.isArray(item)) { | ||
if (dst === list) dst = list.slice(0, i); | ||
flatten(item, dst); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. we could maybe check the length of |
||
} else if (dst !== list) dst.push(item); | ||
} | ||
return dst; | ||
} | ||
|
||
class EventEmitter extends Subject { | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAIK uglify will do this change for us, so we can use
undefined
here for readability