refactor(docs-infra): update loading of custom elements to use dynamic imports #30704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonroberts
added
effort1: hours
refactoring
brandonroberts
force-pushed
the
aio-dynamic-import-elements
branch
from
a3a0491
to
9b246b4
Compare
|
You can preview 9b246b4 at https://pr30704-9b246b4.ngbuilds.io/. |
gkalpak
approved these changes
May 29, 2019
gkalpak
added
the
action: cleanup
brandonroberts
force-pushed
the
aio-dynamic-import-elements
branch
from
9b246b4
to
a932a3b
Compare
|
You can preview a932a3b at https://pr30704-a932a3b.ngbuilds.io/. |
…c import syntax Removes the usage of `NgModuleFactoryLoader` and string-based imports for lazy loading.
… dynamic import syntax
…odules In View Engine, NgModule factories are created for each NgModule and loaded when the module is requested. Ivy doesn't generate the factories by design and only loads the module class, so it must be compiled after being loaded.
brandonroberts
force-pushed
the
aio-dynamic-import-elements
branch
from
a932a3b
to
64afdef
Compare
|
You can preview 64afdef at https://pr30704-64afdef.ngbuilds.io/. |
|
You can preview 8da946f at https://pr30704-8da946f.ngbuilds.io/. |
brandonroberts
force-pushed
the
aio-dynamic-import-elements
branch
from
8da946f
to
c4b31ba
Compare
|
You can preview c4b31ba at https://pr30704-c4b31ba.ngbuilds.io/. |
brandonroberts
removed
the
action: cleanup
|
You can preview f4b447e at https://pr30704-f4b447e.ngbuilds.io/. |
gkalpak
reviewed
May 30, 2019
|
You can preview cbadd28 at https://pr30704-cbadd28.ngbuilds.io/. |
brandonroberts
force-pushed
the
aio-dynamic-import-elements
branch
from
61bb57a
to
cd86d95
Compare
|
You can preview 61bb57a at https://pr30704-61bb57a.ngbuilds.io/. |
|
You can preview cd86d95 at https://pr30704-cd86d95.ngbuilds.io/. |
brandonroberts
force-pushed
the
aio-dynamic-import-elements
branch
from
cd86d95
to
d23517a
Compare
|
You can preview d23517a at https://pr30704-d23517a.ngbuilds.io/. |
brandonroberts
added
the
action: merge
gkalpak
added a commit
to gkalpak/angular
that referenced
this pull request
Jun 7, 2019
… Ivy mode Previously, when switching to Ivy mode (e.g. to run tests on CI), we had to add `allowEmptyCodegenFiles: true` to the `angularCompilerOptions` in `tsconfig.app.json`. This isn't necessary any more (potentially since we switched to dynamic imports for loading lazy modules in angular#30704), so this commit removes it from the `switch-to-ivy.js` script.
gkalpak
added a commit
to gkalpak/angular
that referenced
this pull request
Jun 7, 2019
… Ivy mode Previously, when switching to Ivy mode (e.g. to run tests on CI), we had to add `allowEmptyCodegenFiles: true` to the `angularCompilerOptions` in `tsconfig.app.json`. This isn't necessary any more (potentially since we switched to dynamic imports for loading lazy modules in angular#30704), so this commit removes it from the `switch-to-ivy.js` script.
mhevery
pushed a commit
that referenced
this pull request
Jun 7, 2019
… Ivy mode (#30911) Previously, when switching to Ivy mode (e.g. to run tests on CI), we had to add `allowEmptyCodegenFiles: true` to the `angularCompilerOptions` in `tsconfig.app.json`. This isn't necessary any more (potentially since we switched to dynamic imports for loading lazy modules in #30704), so this commit removes it from the `switch-to-ivy.js` script. PR Close #30911
pull bot
pushed a commit
to Pandinosaurus/angular
that referenced
this pull request
Jun 7, 2019
… Ivy mode (angular#30911) Previously, when switching to Ivy mode (e.g. to run tests on CI), we had to add `allowEmptyCodegenFiles: true` to the `angularCompilerOptions` in `tsconfig.app.json`. This isn't necessary any more (potentially since we switched to dynamic imports for loading lazy modules in angular#30704), so this commit removes it from the `switch-to-ivy.js` script. PR Close angular#30911
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information