Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docs-infra): add v7 in versions dropdown #30775

Closed
wants to merge 1 commit into from
Closed

fix(docs-infra): add v7 in versions dropdown #30775

wants to merge 1 commit into from

Conversation

gkalpak
Copy link
Member

@gkalpak gkalpak commented May 31, 2019

Fixes #30769.

@gkalpak gkalpak requested a review from a team as a code owner May 31, 2019 09:58
@gkalpak gkalpak added comp: docs-infra state: blocked target: patch This PR is targeted for the next patch release type: bug/fix and removed cla: yes labels May 31, 2019
@googlebot
Copy link

☹️ Sorry, but only Googlers may change the label cla: yes.

@ngbot ngbot bot added this to the needsTriage milestone May 31, 2019
@gkalpak gkalpak added this to IN PROGRESS in docs-infra May 31, 2019
@gkalpak gkalpak moved this from IN PROGRESS to REVIEW in docs-infra May 31, 2019
@gkalpak
Copy link
Member Author

gkalpak commented May 31, 2019 •
edited

This is blocked on creating the v7-angular-io project on Firebase and deploying to it. Done

@gkalpak gkalpak mentioned this pull request May 31, 2019
Closed
@mary-poppins
Copy link

You can preview 3b21020 at https://pr30775-3b21020.ngbuilds.io/.

Splaktar
Splaktar approved these changes May 31, 2019
View reviewed changes
Copy link
Member

@Splaktar Splaktar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gkalpak gkalpak added action: merge The PR is ready for merge by the caretaker and removed state: blocked labels May 31, 2019
@brandonroberts brandonroberts added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label May 31, 2019
@brandonroberts
Copy link
Contributor

Caretaker note: I am using a global approval for a docs-only change

@mhevery mhevery closed this in 8ce288a May 31, 2019
mhevery pushed a commit that referenced this pull request May 31, 2019
@gkalpak @mhevery
fix(docs-infra): add v7 in versions dropdown (#30775)
0e17958 
Fixes #30769

PR Close #30775
@gkalpak gkalpak deleted the fix-aio-list-v7 branch June 1, 2019 07:28
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@petebacondarwin petebacondarwin petebacondarwin approved these changes

@brandonroberts brandonroberts brandonroberts approved these changes

@Splaktar Splaktar Splaktar approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: patch This PR is targeted for the next patch release type: bug/fix
Projects
docs-infra
REVIEW
Milestone
docs-infra-aio-app
Development

Successfully merging this pull request may close these issues.

Not found the docs of v7 of Angular in angular.io
6 participants
@gkalpak @googlebot @mary-poppins @brandonroberts @petebacondarwin @Splaktar