Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Set up Build Event Service Configuration for RBE executed bazel #31197

Closed

Conversation

josephperrott
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the new behavior?

Uploads bazel events to the build event service when run with config=remote

@josephperrott josephperrott requested a review from a team as a code owner June 21, 2019 19:44
@josephperrott josephperrott added the target: major This PR is targeted for the next major release label Jun 21, 2019
Copy link
Member

@gkalpak gkalpak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add some more info in the commit message on what is Build Event Service (maybe add a link to https://docs.bazel.build/versions/master/build-event-protocol.html#the-build-event-service or some other relevant resource) and what this PR does (e.g. where does it send the data, when does it send it, etc.).

It might be obvious to people using blaze/bazel for years, but it is not so obvious for the uninitiated 😛

@gkalpak gkalpak added area: build & ci Related the build and CI infrastructure of the project action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Jun 21, 2019
@ngbot ngbot bot modified the milestone: needsTriage Jun 21, 2019
@gkalpak
Copy link
Member

gkalpak commented Jun 21, 2019

OOC, why is this master only?

The Build Event Service (https://docs.bazel.build/versions/master/build-event-protocol.html#the-build-event-service),
allows for build events from bazel builds to be transmitted as opaque bytes to be processed.

Our usage is to send our build events to a Build Event Service an Angular team owned Google Cloud Project which collects
build results and makes each invocation available via a provided URL to view.  The information uploaded includes information
about the build environment, configuration, build status/events, build options, results and actions.

Build Event Protocol Proto: https://github.com/bazelbuild/bazel/blob/0.27.0/src/main/java/com/google/devtools/build/lib/buildeventstream/proto/build_event_stream.proto
@josephperrott
Copy link
Member Author

I marked it as master only since it was only modifying how remote builds are done (so currently only CI in earnest), but I suppose this could target patch as well. Updated.

@josephperrott josephperrott added target: patch This PR is targeted for the next patch release and removed target: major This PR is targeted for the next major release labels Jun 21, 2019
@josephperrott josephperrott added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Jun 21, 2019
kara pushed a commit that referenced this pull request Jun 21, 2019
#31197)

The Build Event Service (https://docs.bazel.build/versions/master/build-event-protocol.html#the-build-event-service),
allows for build events from bazel builds to be transmitted as opaque bytes to be processed.

Our usage is to send our build events to a Build Event Service an Angular team owned Google Cloud Project which collects
build results and makes each invocation available via a provided URL to view.  The information uploaded includes information
about the build environment, configuration, build status/events, build options, results and actions.

Build Event Protocol Proto: https://github.com/bazelbuild/bazel/blob/0.27.0/src/main/java/com/google/devtools/build/lib/buildeventstream/proto/build_event_stream.proto

PR Close #31197
@kara kara closed this in 131e244 Jun 21, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 15, 2019
@josephperrott josephperrott deleted the remote-build-execution branch March 18, 2020 16:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants