Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ivy): use goog.LOCALE for Closure Compiler to define default LOCALE_ID #31519

Closed
wants to merge 2 commits into from
Closed

fix(ivy): use goog.LOCALE for Closure Compiler to define default LOCALE_ID #31519

wants to merge 2 commits into from

Conversation

AndrewKushnir
Copy link
Contributor

Prior to this commit, default value for LOCALE_ID was not setup for Closure Compiler in Ivy. In Closure Compiler, we can use goog.LOCALE as a default value, which will be replaced at build time with current locale.

PR Type

What kind of change does this PR introduce?

  • Bugfix

Does this PR introduce a breaking change?

  • Yes
  • No

@AndrewKushnir AndrewKushnir added type: bug/fix action: review The PR is still awaiting reviews from at least one requested reviewer area: i18n target: major This PR is targeted for the next major release comp: ivy labels Jul 11, 2019
@AndrewKushnir AndrewKushnir requested review from a team as code owners July 11, 2019 22:01
@ngbot ngbot bot added this to the needsTriage milestone Jul 11, 2019
@AndrewKushnir AndrewKushnir added the action: presubmit The PR is in need of a google3 presubmit label Jul 11, 2019
@AndrewKushnir
Copy link
Contributor Author

AndrewKushnir commented Jul 11, 2019 •
edited

kara
kara approved these changes Jul 12, 2019
View reviewed changes
Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AndrewKushnir
Copy link
Contributor Author

Blueprint presubmits look good. I will run global presubmit tonight to make sure this change doesn't break existing projects. Thank you.

@AndrewKushnir
Copy link
Contributor Author

Global TAP Presubmit (VE)

@AndrewKushnir AndrewKushnir added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: presubmit The PR is in need of a google3 presubmit labels Jul 12, 2019
@AndrewKushnir
Copy link
Contributor Author

Global TAP indicated that there are some tests that expect default locale to be defined as en-US and goog.LOCALE just defines it as en. Will need to look into this, marking this PR with "cleanup" label for now.

@AndrewKushnir AndrewKushnir removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Jul 12, 2019
patilharshal16
patilharshal16 approved these changes Jul 12, 2019
View reviewed changes
Copy link

@patilharshal16 patilharshal16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@AndrewKushnir
fix(ivy): use goog.LOCALE for Closure Compiler to define default LOCA…
da54701 
…LE_ID

Prior to this commit, default value for LOCALE_ID was not setup for Closure Compiler. In Closure Compiler, we can use `goog.LOCALE` as a default value, which will be replaced at build time with current locale.
@AndrewKushnir
fixup! fix(ivy): use goog.LOCALE for Closure Compiler to define defau…
bda30c3 
…lt LOCALE_ID
@AndrewKushnir
Copy link
Contributor Author

AndrewKushnir commented Jul 13, 2019 •
edited

New presubmits after updates to use en-US if goog.LOCALE is en:

@AndrewKushnir AndrewKushnir added the action: presubmit The PR is in need of a google3 presubmit label Jul 13, 2019
@kara kara added action: review The PR is still awaiting reviews from at least one requested reviewer and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews action: presubmit The PR is in need of a google3 presubmit labels Jul 15, 2019
@kara kara self-requested a review July 15, 2019 16:04
@kara kara removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Jul 15, 2019
@AndrewKushnir
Copy link
Contributor Author

Global TAP indicated no failures caused by this change, so I'm adding the "merge" label.

@kara kara added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels Jul 15, 2019
@ngbot
Copy link

ngbot bot commented Jul 15, 2019

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure status "ci-codefresh-bazel" is failing
    pending status "google3" is pending
    pending 1 pending code review

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@kara
Copy link
Contributor

kara commented Jul 15, 2019

merge-assistance: global approval

@AndrewKushnir AndrewKushnir mentioned this pull request Jul 15, 2019
Closed
@matsko matsko closed this in 09576e9 Jul 16, 2019
sabeersulaiman pushed a commit to sabeersulaiman/angular that referenced this pull request Sep 6, 2019
@AndrewKushnir @sabeersulaiman
fix(ivy): use goog.LOCALE for Closure Compiler to define default LOCA…
207f16a 
…LE_ID (angular#31519)

Prior to this commit, default value for LOCALE_ID was not setup for Closure Compiler. In Closure Compiler, we can use `goog.LOCALE` as a default value, which will be replaced at build time with current locale.

PR Close angular#31519
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vikerman vikerman vikerman approved these changes

@mhevery mhevery mhevery approved these changes

@patilharshal16 patilharshal16 patilharshal16 approved these changes

@kara kara Awaiting requested review from kara

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: i18n cla: yes merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: major This PR is targeted for the next major release type: bug/fix
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@AndrewKushnir @kara @vikerman @mhevery @patilharshal16 @googlebot