Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(core): fix typo in event-binding code example #31611

Closed
wants to merge 1 commit into from
Closed

docs(core): fix typo in event-binding code example #31611

wants to merge 1 commit into from

Conversation

gkalpak
Copy link
Member

@gkalpak gkalpak commented Jul 17, 2019

item is an object, so it is stringified to [object Object]. Using its name property produces a more meaningful message.

@gkalpak
docs(core): fix typo in event-binding code example
7fdf03c 
`item` is an object, so it is stringified to `[object Object]`. Using
its `name` property produces a more meaningful message.
@gkalpak gkalpak requested a review from a team as a code owner July 17, 2019 16:56
@gkalpak gkalpak added area: core Issues related to the framework runtime comp: docs action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Jul 17, 2019
@ngbot ngbot bot added this to the needsTriage milestone Jul 17, 2019
@gkalpak
Copy link
Member Author

gkalpak commented Jul 17, 2019

To see the change in action, scroll down and click the Delete button:

@mary-poppins
Copy link

You can preview 7fdf03c at https://pr31611-7fdf03c.ngbuilds.io/.

matsko pushed a commit that referenced this pull request Jul 17, 2019
@gkalpak @matsko
docs(core): fix typo in event-binding code example (#31611)
e1cfa41 
`item` is an object, so it is stringified to `[object Object]`. Using
its `name` property produces a more meaningful message.

PR Close #31611
@matsko matsko closed this in 32c07ce Jul 17, 2019
@gkalpak gkalpak deleted the fix-docs-event-binding-example branch July 17, 2019 18:26
sabeersulaiman pushed a commit to sabeersulaiman/angular that referenced this pull request Sep 6, 2019
@gkalpak @sabeersulaiman
docs(core): fix typo in event-binding code example (angular#31611)
9b7793f 
`item` is an object, so it is stringified to `[object Object]`. Using
its `name` property produces a more meaningful message.

PR Close angular#31611
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gkalpak @mary-poppins @googlebot