Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document browser support for service workers #32046

Closed
wants to merge 2 commits into from

Conversation

jbogarthyde
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Behavior of SW apps in browsers that don't support it is not documented.

Issue Number: #21304

What is the new behavior?

Add doc to Service Worker intro.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Content transferred from unfinished PR #22546

@jbogarthyde jbogarthyde added type: bug/fix comp: docs effort1: hours freq1: low aio: preview target: patch This PR is targeted for the next patch release area: service-worker Issues related to the @angular/service-worker package risk: low labels Aug 7, 2019
@jbogarthyde jbogarthyde requested a review from a team as a code owner August 7, 2019 18:18
@jbogarthyde jbogarthyde self-assigned this Aug 7, 2019
@ngbot ngbot bot modified the milestone: Backlog Aug 7, 2019
@jbogarthyde jbogarthyde added this to In Progress in docs Aug 7, 2019
@mary-poppins
Copy link

You can preview ad1396d at https://pr32046-ad1396d.ngbuilds.io/.

aio/content/guide/service-worker-intro.md Outdated Show resolved Hide resolved
aio/content/guide/service-worker-intro.md Outdated Show resolved Hide resolved
aio/content/guide/service-worker-intro.md Show resolved Hide resolved
aio/content/guide/service-worker-intro.md Show resolved Hide resolved
aio/content/guide/service-worker-intro.md Outdated Show resolved Hide resolved
aio/content/guide/service-worker-intro.md Show resolved Hide resolved
@jbogarthyde jbogarthyde moved this from In Progress to In Review in docs Aug 7, 2019
@mary-poppins
Copy link

You can preview 885c995 at https://pr32046-885c995.ngbuilds.io/.

@mary-poppins
Copy link

You can preview a2aea0f at https://pr32046-a2aea0f.ngbuilds.io/.

Copy link
Member

@gkalpak gkalpak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor comments. LGTM otherwise 👍

aio/content/guide/service-worker-intro.md Show resolved Hide resolved
aio/content/guide/service-worker-intro.md Outdated Show resolved Hide resolved
aio/content/guide/service-worker-intro.md Outdated Show resolved Hide resolved
aio/content/guide/service-worker-intro.md Outdated Show resolved Hide resolved
aio/content/guide/service-worker-intro.md Outdated Show resolved Hide resolved
aio/content/guide/service-worker-intro.md Outdated Show resolved Hide resolved
@jbogarthyde jbogarthyde added the action: merge The PR is ready for merge by the caretaker label Aug 12, 2019
@jbogarthyde jbogarthyde moved this from In Review to Waiting for Approval in docs Aug 12, 2019
@jbogarthyde jbogarthyde moved this from Waiting for Approval to Waiting for Merge in docs Aug 12, 2019
@jbogarthyde jbogarthyde removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Aug 12, 2019
@mary-poppins
Copy link

You can preview 376a415 at https://pr32046-376a415.ngbuilds.io/.

@mary-poppins
Copy link

You can preview f8abffa at https://pr32046-f8abffa.ngbuilds.io/.

@kara
Copy link
Contributor

kara commented Aug 13, 2019

@jbogarthyde Looks like George's comments still need to be addressed, so marking this as cleanup

@kara kara added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Aug 13, 2019
@jbogarthyde jbogarthyde removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Aug 13, 2019
@jbogarthyde
Copy link
Contributor Author

oops. incorporated remaining comments.

@mary-poppins
Copy link

You can preview 60a2a83 at https://pr32046-60a2a83.ngbuilds.io/.

@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@gkalpak gkalpak added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Aug 14, 2019
@gkalpak
Copy link
Member

gkalpak commented Aug 14, 2019

@googlebot I consent.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@gkalpak gkalpak removed the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Aug 14, 2019
@mary-poppins
Copy link

You can preview fd52558 at https://pr32046-fd52558.ngbuilds.io/.

AndrewKushnir pushed a commit that referenced this pull request Aug 14, 2019
@jbogarthyde jbogarthyde moved this from Waiting for Merge to Done in docs Aug 14, 2019
@jbogarthyde jbogarthyde deleted the jb-sw-browser-support branch August 19, 2019 15:52
sabeersulaiman pushed a commit to sabeersulaiman/angular that referenced this pull request Sep 6, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker aio: preview area: service-worker Issues related to the @angular/service-worker package cla: yes effort1: hours freq1: low risk: low target: patch This PR is targeted for the next patch release type: bug/fix
Projects
docs
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants