-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document browser support for service workers #32046
Conversation
You can preview ad1396d at https://pr32046-ad1396d.ngbuilds.io/. |
ad1396d
to
885c995
Compare
You can preview 885c995 at https://pr32046-885c995.ngbuilds.io/. |
You can preview a2aea0f at https://pr32046-a2aea0f.ngbuilds.io/. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor comments. LGTM otherwise 👍
a2aea0f
to
376a415
Compare
You can preview 376a415 at https://pr32046-376a415.ngbuilds.io/. |
376a415
to
f8abffa
Compare
You can preview f8abffa at https://pr32046-f8abffa.ngbuilds.io/. |
@jbogarthyde Looks like George's comments still need to be addressed, so marking this as cleanup |
f8abffa
to
60a2a83
Compare
oops. incorporated remaining comments. |
You can preview 60a2a83 at https://pr32046-60a2a83.ngbuilds.io/. |
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
@googlebot I consent. |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
You can preview fd52558 at https://pr32046-fd52558.ngbuilds.io/. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Behavior of SW apps in browsers that don't support it is not documented.
Issue Number: #21304
What is the new behavior?
Add doc to Service Worker intro.
Does this PR introduce a breaking change?
Other information
Content transferred from unfinished PR #22546