Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: remove material-unit-tests failure blocklist #32138

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 0 additions & 8 deletions .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -912,14 +912,6 @@ testing/** @angular/fw-test



# ================================================
# Material CI
# ================================================

/tools/material-ci/** @angular/fw-core @angular/framework-global-approvers



# ================================================
# Public API
# ================================================
Expand Down
40 changes: 40 additions & 0 deletions docs/DEBUG_MATERIAL_IVY.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
# Debugging the Material unit tests job

Currently all changes to Ivy are validated against the test suite of the
`angular/components` repository. In order to debug the `material-unit-tests` CI
job, the following steps can be used:

1\) Build the Ivy package output by running `./scripts/build-ivy-npm-packages.sh` in
the `angular/angular` repo.

2\) Clone the `angular/components` repository if not done yet ([quick link to repo](https://github.com/angular/components)).

3\) Set up the package output in the `components` repository by running the following
command in the `angular/angular` repo:

```bash
node ./scripts/ci/update-deps-to-dist-packages.js {COMPONENTS_REPO}/package.json ./dist/packages-dist-ivy-aot
```

4\) Switch into the `components` repository and run the tests by using the
following command:

```bash
yarn test --deleted_packages=//src/dev-app --define=compile=aot
```

### Running tests for individual entry-points

The `yarn test` script from the `components` repository runs all tests in the project.
This is sometimes not desired because it involves building and testing of all packages
and entry-points. Running tests for an individual entry-point is possible by explicitly
selecting a given test target.

Here is an example of commands that run individual test targets. Note that it is
**important** to specify the `--define=compile=aot` flag in order to run tests with Ivy.
devversion marked this conversation as resolved.
Show resolved Hide resolved

```bash
yarn bazel test --define=compile=aot src/material/slider:unit_tests
yarn bazel test --define=compile=aot src/cdk/a11y:unit_tests
yarn bazel test --define=compile=aot src/material/toolbar:unit_tests
```
4 changes: 0 additions & 4 deletions scripts/ci/run_angular_material_unit_tests.sh
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,6 @@ cd ${MATERIAL_REPO_TMP_DIR}
# Note that it's not necessary to perform a yarn install, as Bazel performs its own yarn install.
node ${angular_dir}/scripts/ci/update-deps-to-dist-packages.js ${MATERIAL_REPO_TMP_DIR}/package.json ${angular_dir}/dist/packages-dist-ivy-aot/

# Append the test blocklist into angular/material2's karma-test-shim.js.
# This filters out known-failing tests because the goal is to prevent regressions.
cat ${angular_dir}/tools/material-ci/angular_material_test_blocklist.js >> ./test/karma-test-shim.js

# Create a symlink for the Bazel binary installed through NPM, as running through Yarn introduces OOM errors.
./scripts/circleci/setup_bazel_binary.sh

Expand Down
20 changes: 0 additions & 20 deletions tools/material-ci/angular_material_test_blocklist.js

This file was deleted.

24 changes: 0 additions & 24 deletions tools/material-ci/instructions.md

This file was deleted.